You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This should instead have an interface dependency, to account for apps doing weirder things with their staking modules. E.g. Osmosis superfluid staking, we really need to look at what IBC depends on, to determine what we should be returning.
Also would recommend renaming to GetIBCTestingStakingKeeper as part of this.
Problem Definition
The current design inhibits modularity of ibctesting, for a small reason.
Proposal
Define an interface for what keeper methods IBC depends on from the staking keeper, and then define an interface accordingly. Use that interface in the required ibctesting app interface.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged/assigned
The text was updated successfully, but these errors were encountered:
Summary
The IBCtesting
GetStakingKeeper
required interface method (https://github.com/cosmos/ibc-go/blob/main/testing/app.go#L39) should not depend on the literal staking keeper in the hub.This should instead have an interface dependency, to account for apps doing weirder things with their staking modules. E.g. Osmosis superfluid staking, we really need to look at what IBC depends on, to determine what we should be returning.
Also would recommend renaming to
GetIBCTestingStakingKeeper
as part of this.Problem Definition
The current design inhibits modularity of ibctesting, for a small reason.
Proposal
Define an interface for what keeper methods IBC depends on from the staking keeper, and then define an interface accordingly. Use that interface in the required ibctesting app interface.
For Admin Use
The text was updated successfully, but these errors were encountered: