Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make SendTransfer private #1918

Closed
3 tasks
colin-axner opened this issue Aug 8, 2022 · 0 comments · Fixed by #2446
Closed
3 tasks

make SendTransfer private #1918

colin-axner opened this issue Aug 8, 2022 · 0 comments · Fixed by #2446
Assignees
@colin-axner
Labels
20-transfer type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
v6.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

We should make the rpc handler Transfer be the only entry point for sending ibc transfers

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added 20-transfer type: code hygiene Clean up code but without changing functionality or interfaces labels Aug 8, 2022
@colin-axner colin-axner self-assigned this Aug 8, 2022
@crodriguezvega crodriguezvega mentioned this issue Aug 11, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Aug 14, 2022
@crodriguezvega crodriguezvega moved this from Todo to Backlog in ibc-go Sep 22, 2022
@crodriguezvega crodriguezvega mentioned this issue Sep 25, 2022
Merged
9 tasks
@colin-axner colin-axner mentioned this issue Sep 28, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega added this to the v6.0.0 milestone Sep 28, 2022
@crodriguezvega crodriguezvega moved this from Backlog to In progress in ibc-go Sep 28, 2022
@colin-axner colin-axner mentioned this issue Sep 29, 2022
Merged
9 tasks
@colin-axner colin-axner moved this from In progress to In review in ibc-go Oct 3, 2022
mergify bot pushed a commit that referenced this issue Oct 11, 2022
@colin-axner
refactor: remove SendTransfer, require IBC transfers to be initiated …
24b17bd 
…with MsgTransfer (#2446)

## Description



closes: #1918 

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [x] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [x] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [x] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [x] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [x] Re-reviewed `Files changed` in the Github PR explorer
- [x] Review `Codecov Report` in the comment section below once CI passes
@mergify mergify bot closed this as completed in #2446 Oct 11, 2022
Repository owner moved this from In review to Done in ibc-go Oct 11, 2022
mergify bot pushed a commit that referenced this issue Oct 11, 2022
@colin-axner @mergify
refactor: remove SendTransfer, require IBC transfers to be initiated …
12401d1 
…with MsgTransfer (#2446)

## Description

closes: #1918

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [x] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [x] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [x] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [x] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [x] Re-reviewed `Files changed` in the Github PR explorer
- [x] Review `Codecov Report` in the comment section below once CI passes

(cherry picked from commit 24b17bd)

# Conflicts:
#	modules/apps/transfer/keeper/mbt_relay_test.go
#	modules/apps/transfer/keeper/msg_server_test.go
#	modules/apps/transfer/keeper/relay.go
#	modules/apps/transfer/keeper/relay_test.go
crodriguezvega added a commit that referenced this issue Oct 19, 2022
@mergify @colin-axner @crodriguezvega
refactor: remove SendTransfer, require IBC transfers to be initiated …
4510bc5 
…with MsgTransfer (backport #2446) (#2527)

* refactor: remove SendTransfer, require IBC transfers to be initiated with MsgTransfer (#2446)

## Description

closes: #1918

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [x] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [x] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [x] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [x] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [x] Re-reviewed `Files changed` in the Github PR explorer
- [x] Review `Codecov Report` in the comment section below once CI passes

(cherry picked from commit 24b17bd)

# Conflicts:
#	modules/apps/transfer/keeper/mbt_relay_test.go
#	modules/apps/transfer/keeper/msg_server_test.go
#	modules/apps/transfer/keeper/relay.go
#	modules/apps/transfer/keeper/relay_test.go

* fix test

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
20-transfer type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Archived in project
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

refactor: remove SendTransfer, require IBC transfers to be initiated with MsgTransfer cosmos/ibc-go
2 participants
@crodriguezvega @colin-axner