Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure solomachine marshals nil and []byte in sign bytes the same #1914

Closed
3 tasks
colin-axner opened this issue Aug 8, 2022 · 0 comments · Fixed by #2742
Closed
3 tasks

Ensure solomachine marshals nil and []byte in sign bytes the same #1914

colin-axner opened this issue Aug 8, 2022 · 0 comments · Fixed by #2742
Assignees
@chatton
Labels
06-solomachine
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

Summary

For VerifyNonMembership, we should write a test to ensure proto marshaling "nil" and "[]byte{}" result in the same value

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added this to the 02-client refactor beta milestone Aug 8, 2022
@colin-axner colin-axner mentioned this issue Aug 8, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Aug 19, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Nov 1, 2022
@chatton chatton self-assigned this Nov 14, 2022
@chatton chatton mentioned this issue Nov 14, 2022
Merged
9 tasks
@charleenfei charleenfei moved this from Todo to In review in ibc-go Nov 14, 2022
Repository owner moved this from In review to Todo in ibc-go Nov 15, 2022
@damiannolan damiannolan moved this from Todo to Done in ibc-go Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
06-solomachine
Projects
ibc-go
Status: Done 🥳
Milestone
02-client refactor beta
Development

Successfully merging a pull request may close this issue.

Ensure solomachine marshals nil and []byte in sign bytes the same cosmos/ibc-go
2 participants
@chatton @colin-axner