Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setClientState function to 06-solomachine #1887

Closed
3 tasks
colin-axner opened this issue Aug 4, 2022 · 1 comment
Closed
3 tasks

Add setClientState function to 06-solomachine #1887

colin-axner opened this issue Aug 4, 2022 · 1 comment
Assignees
@damiannolan
Labels
06-solomachine
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

Summary

Each time we set the client state in store, we should use a private helper function like 07-tendermint does. It may exist already, but we do not use it in update.go

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner mentioned this issue Aug 4, 2022
Merged
9 tasks
@damiannolan damiannolan self-assigned this Aug 5, 2022
@damiannolan damiannolan moved this to In progress in ibc-go Aug 5, 2022
@damiannolan damiannolan mentioned this issue Aug 5, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega moved this from In progress to In review in ibc-go Aug 5, 2022
@crodriguezvega crodriguezvega added this to the 02-client refactor beta milestone Aug 5, 2022
@colin-axner
Copy link
Contributor Author

closed by #1891

Repository owner moved this from In review to Done in ibc-go Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
06-solomachine
Projects
No open projects
ibc-go
Archived in project
Milestone
02-client refactor beta
Development

No branches or pull requests
3 participants
@damiannolan @crodriguezvega @colin-axner