-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: proto-update-deps target on macOS #1838
fix: proto-update-deps target on macOS #1838
Conversation
Thanks for fixing this! Testing on a GNU system I get:
|
3ad31ae
to
9bbf5c3
Compare
Yeah, silly me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me on Ubuntu 👍
9bbf5c3
to
e8a4fff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
In a nerdy industry, this is one of the nerdiest PR's I've seen -- and quite useful, too! Thanks! PS: Who wrote the migration docs that included the line "on a gnu/linux machine....."? epic (at the time, they were the finest/only migration docs. I upgraded several chains following those instructions.) |
thanks again @nicopernas :) |
Description
As noted in #1798, the
proto-update-deps
make
target is broken on macOS. The culprit is ased
command that works slightly different in its freebsd implementation.This PR replaces the
sed
command in the makefile target with aperl
oneliner that is arguably easier to read and it works on both macOS and GNU systems.This only fixes part of the problem described in #1798 though.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes