Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ics29 fee validation: return errors immediately #1234

Closed
3 tasks
damiannolan opened this issue Apr 8, 2022 · 0 comments
Closed
3 tasks

ics29 fee validation: return errors immediately #1234

damiannolan opened this issue Apr 8, 2022 · 0 comments
Assignees
@damiannolan
Labels
29-fee
Milestone
Fee middleware beta

Comments

@damiannolan
Copy link
Member

Summary

Return errors immediately as opposed to appending them as suggested in:
#276 (comment)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan self-assigned this Apr 8, 2022
@damiannolan damiannolan moved this to In progress in ibc-go Apr 8, 2022
@damiannolan damiannolan added this to the Fee middleware beta milestone Apr 8, 2022
@damiannolan damiannolan mentioned this issue Apr 8, 2022
Closed
9 tasks
@damiannolan damiannolan moved this from In progress to In review in ibc-go Apr 8, 2022
Repository owner moved this from In review to Done in ibc-go Apr 9, 2022
@chatton chatton mentioned this issue Nov 8, 2022
Merged
9 tasks
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tuxcanfly
specs: state executor (cosmos#1234)
394eacb 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware beta
Development

Successfully merging a pull request may close this issue.

chore: ics29 error returns on fee validation cosmos/ibc-go
1 participant
@damiannolan