Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running make proto-all fails with protobuf lint error #1142

Closed
3 tasks
damiannolan opened this issue Mar 18, 2022 · 0 comments · Fixed by #1143
Closed
3 tasks

Running make proto-all fails with protobuf lint error #1142

damiannolan opened this issue Mar 18, 2022 · 0 comments · Fixed by #1143
Assignees
Labels
type: bug Something isn't working as expected

Comments

@damiannolan
Copy link
Member

Summary of Bug

Running make proto-all fails with protobuf lint error: "Enum value name \"...\" should be prefixed with \"RESPONSE_RESULT_TYPE_\"."

Steps to Reproduce

make proto-all
Formatting Protobuf files
{"path":"proto/ibc/core/channel/v1/tx.proto","start_line":50,"start_column":3,"end_line":50,"end_column":30,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"RESPONSE_RESULT_UNSPECIFIED\" should be prefixed with \"RESPONSE_RESULT_TYPE_\"."}
{"path":"proto/ibc/core/channel/v1/tx.proto","start_line":52,"start_column":3,"end_line":52,"end_column":23,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"RESPONSE_RESULT_NOOP\" should be prefixed with \"RESPONSE_RESULT_TYPE_\"."}
{"path":"proto/ibc/core/channel/v1/tx.proto","start_line":54,"start_column":3,"end_line":54,"end_column":26,"type":"ENUM_VALUE_PREFIX","message":"Enum value name \"RESPONSE_RESULT_SUCCESS\" should be prefixed with \"RESPONSE_RESULT_TYPE_\"."}
make: *** [proto-lint] Error 100

Proposal

Update the ResponseResultType enums to include _TYPE in the prefix.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan self-assigned this Mar 18, 2022
@damiannolan damiannolan added the type: bug Something isn't working as expected label Mar 18, 2022
@crodriguezvega crodriguezvega moved this to In review in ibc-go Mar 21, 2022
Repository owner moved this from In review to Done in ibc-go Mar 21, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

Closes: cosmos#884 

Applies the fix described in
rollkit/rollkit#884 (comment) -
update the store height before pushing the block to DA so that the store
height accessed in `trySyncNextBlock` is updated.

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working as expected
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant