Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ics29 protodoc comments #1004

Closed
3 tasks
damiannolan opened this issue Feb 24, 2022 · 1 comment
Closed
3 tasks

Update ics29 protodoc comments #1004

damiannolan opened this issue Feb 24, 2022 · 1 comment
Assignees
@damiannolan
Labels
29-fee
Milestone
Fee middleware alpha

Comments

@damiannolan
Copy link
Member

Summary

Protobuf documentation comments should be included for all ics29 fee message types.
This should include a brief msg description as well as inline comments for each field in lowercase, following the same standards used throughout the ibc-go protobuf definitions.

See 04-channel protodocs for reference

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Feb 28, 2022
@crodriguezvega crodriguezvega added this to the Fee Middleware milestone Feb 28, 2022
@damiannolan damiannolan self-assigned this Mar 1, 2022
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Mar 2, 2022
@damiannolan damiannolan mentioned this issue Mar 3, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega moved this from In progress to In review in ibc-go Mar 3, 2022
Repository owner moved this from In review to Done in ibc-go Mar 4, 2022
@charleenfei
Copy link
Contributor

pr merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware alpha
Development

No branches or pull requests
3 participants
@damiannolan @crodriguezvega @charleenfei