From b083e374cb8d0f8e821ee3c21fdfd90fa4fd0a9c Mon Sep 17 00:00:00 2001 From: Dzung Do | Decentrio Date: Fri, 28 Jun 2024 19:20:03 +0700 Subject: [PATCH] chore(api!): mark MsgModuleQuerySafe requests field as non-nullable (#6598) * Mark MsgModuleQuerySafe requests field as non-nullable * fix e2e tests and docs * add changelog and update migration docs * Update 13-v8-to-v9.md --------- Co-authored-by: DimitrisJim Co-authored-by: Carlos Rodriguez --- CHANGELOG.md | 1 + .../02-interchain-accounts/05-messages.md | 2 +- docs/docs/05-migrations/13-v8-to-v9.md | 10 ++++ e2e/tests/interchain_accounts/query_test.go | 2 +- .../host/keeper/msg_server_test.go | 8 +-- .../host/keeper/relay_test.go | 2 +- .../27-interchain-accounts/host/types/msgs.go | 2 +- .../host/types/msgs_test.go | 10 ++-- .../host/types/tx.pb.go | 60 +++++++++---------- .../interchain_accounts/host/v1/tx.proto | 2 +- 10 files changed, 55 insertions(+), 44 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 747cc70957b..74834f51b28 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -58,6 +58,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ * (apps/27-interchain-accounts) [\#6433](https://github.com/cosmos/ibc-go/pull/6433) Use UNORDERED as the default ordering for new ICA channels. * (apps/transfer) [\#6440](https://github.com/cosmos/ibc-go/pull/6440) Remove `GetPrefixedDenom`. * (apps/transfer) [\#6508](https://github.com/cosmos/ibc-go/pull/6508) Remove the `DenomTrace` type. +* (apps/27-interchain-accounts) [\#6598](https://github.com/cosmos/ibc-go/pull/6598) Mark the `requests` repeated field of `MsgModuleQuerySafe` non-nullable. * (23-commmitment) [\#6633](https://github.com/cosmos/ibc-go/pull/6633) MerklePath has been changed to use `repeated bytes` in favour of `repeated strings`. ### State Machine Breaking diff --git a/docs/docs/02-apps/02-interchain-accounts/05-messages.md b/docs/docs/02-apps/02-interchain-accounts/05-messages.md index 69599f03538..fa5833bd976 100644 --- a/docs/docs/02-apps/02-interchain-accounts/05-messages.md +++ b/docs/docs/02-apps/02-interchain-accounts/05-messages.md @@ -130,7 +130,7 @@ balanceQuery := banktypes.NewQueryBalanceRequest("cosmos1...", "uatom") queryBz, err := balanceQuery.Marshal() // signer of message must be the interchain account on the host -queryMsg := icahosttypes.NewMsgModuleQuerySafe("cosmos2...", []*icahosttypes.QueryRequest{ +queryMsg := icahosttypes.NewMsgModuleQuerySafe("cosmos2...", []icahosttypes.QueryRequest{ { Path: "/cosmos.bank.v1beta1.Query/Balance", Data: queryBz, diff --git a/docs/docs/05-migrations/13-v8-to-v9.md b/docs/docs/05-migrations/13-v8-to-v9.md index ebeb98b477b..0791be7d591 100644 --- a/docs/docs/05-migrations/13-v8-to-v9.md +++ b/docs/docs/05-migrations/13-v8-to-v9.md @@ -95,6 +95,16 @@ func (k Keeper) RegisterInterchainAccount( ) error { ``` +The `requests` repeated field of `MsgModuleQuerySafe` has been marked non-nullable, and therefore the signature of the constructor function `NewMsgModuleQuerySafe` has been updated: + +```diff +func NewMsgModuleQuerySafe( + signer string, +- requests []*QueryRequest, ++ requests []QueryRequest, +) *MsgModuleQuerySafe { +``` + ## Relayers - Renaming of event attribute keys in [#5603](https://github.com/cosmos/ibc-go/pull/5603). diff --git a/e2e/tests/interchain_accounts/query_test.go b/e2e/tests/interchain_accounts/query_test.go index 7c864bf70c7..cd648b19455 100644 --- a/e2e/tests/interchain_accounts/query_test.go +++ b/e2e/tests/interchain_accounts/query_test.go @@ -82,7 +82,7 @@ func (s *InterchainAccountsQueryTestSuite) TestInterchainAccountsQuery() { queryBz, err := balanceQuery.Marshal() s.Require().NoError(err) - queryMsg := icahosttypes.NewMsgModuleQuerySafe(hostAccount, []*icahosttypes.QueryRequest{ + queryMsg := icahosttypes.NewMsgModuleQuerySafe(hostAccount, []icahosttypes.QueryRequest{ { Path: "/cosmos.bank.v1beta1.Query/Balance", Data: queryBz, diff --git a/modules/apps/27-interchain-accounts/host/keeper/msg_server_test.go b/modules/apps/27-interchain-accounts/host/keeper/msg_server_test.go index d358303fc12..54d95d7c02b 100644 --- a/modules/apps/27-interchain-accounts/host/keeper/msg_server_test.go +++ b/modules/apps/27-interchain-accounts/host/keeper/msg_server_test.go @@ -32,7 +32,7 @@ func (suite *KeeperTestSuite) TestModuleQuerySafe() { Data: balanceQueryBz, } - msg = types.NewMsgModuleQuerySafe(suite.chainA.GetSimApp().ICAHostKeeper.GetAuthority(), []*types.QueryRequest{&queryReq}) + msg = types.NewMsgModuleQuerySafe(suite.chainA.GetSimApp().ICAHostKeeper.GetAuthority(), []types.QueryRequest{queryReq}) balance := suite.chainA.GetSimApp().BankKeeper.GetBalance(suite.chainA.GetContext(), suite.chainA.SenderAccount.GetAddress(), sdk.DefaultBondDenom) @@ -64,7 +64,7 @@ func (suite *KeeperTestSuite) TestModuleQuerySafe() { Data: paramsQueryBz, } - msg = types.NewMsgModuleQuerySafe(suite.chainA.GetSimApp().ICAHostKeeper.GetAuthority(), []*types.QueryRequest{&queryReq, ¶msQueryReq}) + msg = types.NewMsgModuleQuerySafe(suite.chainA.GetSimApp().ICAHostKeeper.GetAuthority(), []types.QueryRequest{queryReq, paramsQueryReq}) balance := suite.chainA.GetSimApp().BankKeeper.GetBalance(suite.chainA.GetContext(), suite.chainA.SenderAccount.GetAddress(), sdk.DefaultBondDenom) @@ -102,7 +102,7 @@ func (suite *KeeperTestSuite) TestModuleQuerySafe() { Data: paramsQueryBz, } - msg = types.NewMsgModuleQuerySafe(suite.chainA.GetSimApp().ICAHostKeeper.GetAuthority(), []*types.QueryRequest{&queryReq, ¶msQueryReq}) + msg = types.NewMsgModuleQuerySafe(suite.chainA.GetSimApp().ICAHostKeeper.GetAuthority(), []types.QueryRequest{queryReq, paramsQueryReq}) }, ibcerrors.ErrInvalidRequest, }, @@ -117,7 +117,7 @@ func (suite *KeeperTestSuite) TestModuleQuerySafe() { Data: balanceQueryBz, } - msg = types.NewMsgModuleQuerySafe(suite.chainA.GetSimApp().ICAHostKeeper.GetAuthority(), []*types.QueryRequest{&queryReq}) + msg = types.NewMsgModuleQuerySafe(suite.chainA.GetSimApp().ICAHostKeeper.GetAuthority(), []types.QueryRequest{queryReq}) }, ibcerrors.ErrInvalidRequest, }, diff --git a/modules/apps/27-interchain-accounts/host/keeper/relay_test.go b/modules/apps/27-interchain-accounts/host/keeper/relay_test.go index bcef1c4f900..7a23ae941b8 100644 --- a/modules/apps/27-interchain-accounts/host/keeper/relay_test.go +++ b/modules/apps/27-interchain-accounts/host/keeper/relay_test.go @@ -286,7 +286,7 @@ func (suite *KeeperTestSuite) TestOnRecvPacket() { queryBz, err := balanceQuery.Marshal() suite.Require().NoError(err) - msg := types.NewMsgModuleQuerySafe(interchainAccountAddr, []*types.QueryRequest{ + msg := types.NewMsgModuleQuerySafe(interchainAccountAddr, []types.QueryRequest{ { Path: "/cosmos.bank.v1beta1.Query/Balance", Data: queryBz, diff --git a/modules/apps/27-interchain-accounts/host/types/msgs.go b/modules/apps/27-interchain-accounts/host/types/msgs.go index 092ff1df850..5757dc77fc8 100644 --- a/modules/apps/27-interchain-accounts/host/types/msgs.go +++ b/modules/apps/27-interchain-accounts/host/types/msgs.go @@ -35,7 +35,7 @@ func (msg MsgUpdateParams) ValidateBasic() error { } // NewMsgModuleQuerySafe creates a new MsgModuleQuerySafe instance -func NewMsgModuleQuerySafe(signer string, requests []*QueryRequest) *MsgModuleQuerySafe { +func NewMsgModuleQuerySafe(signer string, requests []QueryRequest) *MsgModuleQuerySafe { return &MsgModuleQuerySafe{ Signer: signer, Requests: requests, diff --git a/modules/apps/27-interchain-accounts/host/types/msgs_test.go b/modules/apps/27-interchain-accounts/host/types/msgs_test.go index eb088d7c597..784f3646ce1 100644 --- a/modules/apps/27-interchain-accounts/host/types/msgs_test.go +++ b/modules/apps/27-interchain-accounts/host/types/msgs_test.go @@ -77,7 +77,7 @@ func TestMsgUpdateParamsGetSigners(t *testing.T) { } func TestMsgModuleQuerySafeValidateBasic(t *testing.T) { - queryRequest := &types.QueryRequest{ + queryRequest := types.QueryRequest{ Path: "/cosmos.bank.v1beta1.Query/Balance", Data: []byte{}, } @@ -89,17 +89,17 @@ func TestMsgModuleQuerySafeValidateBasic(t *testing.T) { }{ { "success: valid signer address", - types.NewMsgModuleQuerySafe(sdk.AccAddress(ibctesting.TestAccAddress).String(), []*types.QueryRequest{queryRequest}), + types.NewMsgModuleQuerySafe(sdk.AccAddress(ibctesting.TestAccAddress).String(), []types.QueryRequest{queryRequest}), nil, }, { "failure: invalid signer address", - types.NewMsgModuleQuerySafe("signer", []*types.QueryRequest{queryRequest}), + types.NewMsgModuleQuerySafe("signer", []types.QueryRequest{queryRequest}), ibcerrors.ErrInvalidAddress, }, { "failure: empty query requests", - types.NewMsgModuleQuerySafe(sdk.AccAddress(ibctesting.TestAccAddress).String(), []*types.QueryRequest{}), + types.NewMsgModuleQuerySafe(sdk.AccAddress(ibctesting.TestAccAddress).String(), []types.QueryRequest{}), ibcerrors.ErrInvalidRequest, }, } @@ -135,7 +135,7 @@ func TestMsgModuleQuerySafeGetSigners(t *testing.T) { tc := tc t.Run(tc.name, func(t *testing.T) { - msg := types.NewMsgModuleQuerySafe(tc.address.String(), []*types.QueryRequest{}) + msg := types.NewMsgModuleQuerySafe(tc.address.String(), []types.QueryRequest{}) encodingCfg := moduletestutil.MakeTestEncodingConfig(ica.AppModuleBasic{}) signers, _, err := encodingCfg.Codec.GetMsgV1Signers(msg) if tc.expPass { diff --git a/modules/apps/27-interchain-accounts/host/types/tx.pb.go b/modules/apps/27-interchain-accounts/host/types/tx.pb.go index 8663234557f..fd74a84741f 100644 --- a/modules/apps/27-interchain-accounts/host/types/tx.pb.go +++ b/modules/apps/27-interchain-accounts/host/types/tx.pb.go @@ -114,7 +114,7 @@ type MsgModuleQuerySafe struct { // signer address Signer string `protobuf:"bytes,1,opt,name=signer,proto3" json:"signer,omitempty"` // requests defines the module safe queries to execute. - Requests []*QueryRequest `protobuf:"bytes,2,rep,name=requests,proto3" json:"requests,omitempty"` + Requests []QueryRequest `protobuf:"bytes,2,rep,name=requests,proto3" json:"requests"` } func (m *MsgModuleQuerySafe) Reset() { *m = MsgModuleQuerySafe{} } @@ -217,36 +217,36 @@ func init() { } var fileDescriptor_fa437afde7f1e7ae = []byte{ - // 456 bytes of a gzipped FileDescriptorProto + // 457 bytes of a gzipped FileDescriptorProto 0x1f, 0x8b, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0xff, 0xa4, 0x93, 0x41, 0x6b, 0xd4, 0x40, 0x14, 0xc7, 0x33, 0x6d, 0x5d, 0xec, 0xb4, 0x50, 0x08, 0x62, 0x6b, 0x90, 0xb4, 0xec, 0x69, 0x29, - 0xee, 0x0c, 0x5d, 0x95, 0x4a, 0x41, 0x90, 0x82, 0x20, 0x42, 0x40, 0x47, 0xf4, 0xe0, 0x45, 0x26, - 0xb3, 0xe3, 0x64, 0xa0, 0xc9, 0xc4, 0xbc, 0xc9, 0x62, 0x6f, 0xe2, 0xc9, 0x93, 0x78, 0xd0, 0xa3, - 0xe0, 0x47, 0xe8, 0x77, 0xf0, 0xd2, 0x63, 0x8f, 0x9e, 0x44, 0x76, 0x0f, 0xfd, 0x1a, 0x92, 0x49, - 0xda, 0xda, 0xd4, 0x1e, 0x42, 0x6f, 0x99, 0x64, 0xfe, 0xbf, 0xf7, 0x7b, 0x99, 0x79, 0xf8, 0xbe, - 0x8e, 0x05, 0xe5, 0x79, 0xbe, 0xa7, 0x05, 0xb7, 0xda, 0x64, 0x40, 0x75, 0x66, 0x65, 0x21, 0x12, - 0xae, 0xb3, 0x37, 0x5c, 0x08, 0x53, 0x66, 0x16, 0x68, 0x62, 0xc0, 0xd2, 0xc9, 0x16, 0xb5, 0xef, - 0x49, 0x5e, 0x18, 0x6b, 0xfc, 0x3b, 0x3a, 0x16, 0xe4, 0xdf, 0x18, 0xf9, 0x4f, 0x8c, 0x54, 0x31, - 0x32, 0xd9, 0x0a, 0x6e, 0x28, 0xa3, 0x8c, 0x0b, 0xd2, 0xea, 0xa9, 0x66, 0x04, 0xab, 0xc2, 0x40, - 0x6a, 0x80, 0xa6, 0xa0, 0x2a, 0x76, 0x0a, 0xaa, 0xf9, 0xb0, 0xdd, 0xc9, 0xc9, 0x15, 0x71, 0xc1, - 0xfe, 0x67, 0x84, 0x57, 0x22, 0x50, 0x2f, 0xf3, 0x31, 0xb7, 0xf2, 0x19, 0x2f, 0x78, 0x0a, 0xfe, - 0x4d, 0xdc, 0x03, 0xad, 0x32, 0x59, 0xac, 0xa1, 0x0d, 0x34, 0x58, 0x64, 0xcd, 0xca, 0x67, 0xb8, - 0x97, 0xbb, 0x1d, 0x6b, 0x73, 0x1b, 0x68, 0xb0, 0x34, 0xba, 0x47, 0xba, 0xb4, 0x44, 0x6a, 0xfa, - 0xee, 0xc2, 0xe1, 0xef, 0x75, 0x8f, 0x35, 0xa4, 0x9d, 0x95, 0x4f, 0x3f, 0xd6, 0xbd, 0x8f, 0xc7, - 0x07, 0x9b, 0x4d, 0x91, 0xfe, 0x2d, 0xbc, 0xda, 0xf2, 0x61, 0x12, 0x72, 0x93, 0x81, 0xec, 0x7f, - 0x43, 0xd8, 0x8f, 0x40, 0x45, 0x66, 0x5c, 0xee, 0xc9, 0xe7, 0xa5, 0x2c, 0xf6, 0x5f, 0xf0, 0xb7, - 0xf2, 0x52, 0xdd, 0x57, 0xf8, 0x7a, 0x21, 0xdf, 0x95, 0x12, 0x6c, 0x25, 0x3c, 0x3f, 0x58, 0x1a, - 0xed, 0x74, 0x13, 0x76, 0x25, 0x58, 0x8d, 0x60, 0xa7, 0xac, 0x8b, 0xca, 0x0c, 0x07, 0x17, 0xb5, - 0x4e, 0xac, 0x2b, 0xbd, 0x44, 0x6a, 0x95, 0x58, 0xa7, 0xb7, 0xc0, 0x9a, 0x95, 0x7f, 0x1b, 0x2f, - 0x16, 0xcd, 0x9e, 0xda, 0x6f, 0x99, 0x9d, 0xbd, 0x18, 0xfd, 0x9c, 0xc3, 0xf3, 0x11, 0x28, 0xff, - 0x2b, 0xc2, 0xcb, 0xe7, 0x0e, 0xe7, 0x61, 0xb7, 0x1e, 0x5a, 0xff, 0x32, 0x78, 0x7c, 0xa5, 0xf8, - 0x69, 0x53, 0xdf, 0xab, 0x6b, 0xd3, 0x3a, 0x87, 0x47, 0x9d, 0xd1, 0x2d, 0x42, 0xf0, 0xe4, 0xaa, - 0x84, 0x13, 0xbf, 0xe0, 0xda, 0x87, 0xe3, 0x83, 0x4d, 0xb4, 0x3b, 0x3e, 0x9c, 0x86, 0xe8, 0x68, - 0x1a, 0xa2, 0x3f, 0xd3, 0x10, 0x7d, 0x99, 0x85, 0xde, 0xd1, 0x2c, 0xf4, 0x7e, 0xcd, 0x42, 0xef, - 0xf5, 0x53, 0xa5, 0x6d, 0x52, 0xc6, 0x44, 0x98, 0x94, 0x36, 0x43, 0xa5, 0x63, 0x31, 0x54, 0x86, - 0x4e, 0x1e, 0xd0, 0xd4, 0x51, 0xa1, 0x1a, 0x28, 0xa0, 0xa3, 0xed, 0xe1, 0x99, 0xc4, 0xf0, 0xfc, - 0x2c, 0xd9, 0xfd, 0x5c, 0x42, 0xdc, 0x73, 0xa3, 0x74, 0xf7, 0x6f, 0x00, 0x00, 0x00, 0xff, 0xff, - 0x49, 0x5c, 0x48, 0xd7, 0x19, 0x04, 0x00, 0x00, + 0xee, 0x0c, 0x5d, 0x95, 0x4a, 0x41, 0x90, 0x82, 0x20, 0xc2, 0x82, 0x8e, 0x78, 0x11, 0x41, 0x26, + 0xb3, 0xe3, 0x64, 0xa0, 0xc9, 0xc4, 0xbc, 0xc9, 0x62, 0x6f, 0xe2, 0xc9, 0x93, 0x78, 0xf0, 0x26, + 0x82, 0x1f, 0xa1, 0xdf, 0xc1, 0x4b, 0x8f, 0x3d, 0x7a, 0x12, 0xd9, 0x3d, 0xf4, 0x6b, 0x48, 0x66, + 0xa7, 0xad, 0x4d, 0xed, 0x21, 0xf4, 0x96, 0x49, 0xe6, 0xff, 0x7b, 0xbf, 0x97, 0x99, 0x87, 0xef, + 0xeb, 0x44, 0x50, 0x5e, 0x14, 0x7b, 0x5a, 0x70, 0xab, 0x4d, 0x0e, 0x54, 0xe7, 0x56, 0x96, 0x22, + 0xe5, 0x3a, 0x7f, 0xc3, 0x85, 0x30, 0x55, 0x6e, 0x81, 0xa6, 0x06, 0x2c, 0x1d, 0x6f, 0x51, 0xfb, + 0x9e, 0x14, 0xa5, 0xb1, 0x26, 0xbc, 0xa3, 0x13, 0x41, 0xfe, 0x8d, 0x91, 0xff, 0xc4, 0x48, 0x1d, + 0x23, 0xe3, 0xad, 0xe8, 0x86, 0x32, 0xca, 0xb8, 0x20, 0xad, 0x9f, 0x66, 0x8c, 0x68, 0x55, 0x18, + 0xc8, 0x0c, 0xd0, 0x0c, 0x54, 0xcd, 0xce, 0x40, 0xf9, 0x0f, 0xdb, 0xad, 0x9c, 0x5c, 0x11, 0x17, + 0xec, 0x7e, 0x46, 0x78, 0x65, 0x08, 0xea, 0x65, 0x31, 0xe2, 0x56, 0x3e, 0xe3, 0x25, 0xcf, 0x20, + 0xbc, 0x89, 0x3b, 0xa0, 0x55, 0x2e, 0xcb, 0x35, 0xb4, 0x81, 0x7a, 0x8b, 0xcc, 0xaf, 0x42, 0x86, + 0x3b, 0x85, 0xdb, 0xb1, 0x36, 0xb7, 0x81, 0x7a, 0x4b, 0x83, 0x7b, 0xa4, 0x4d, 0x4b, 0x64, 0x46, + 0xdf, 0x5d, 0x38, 0xfc, 0xbd, 0x1e, 0x30, 0x4f, 0xda, 0x59, 0xf9, 0xf4, 0x63, 0x3d, 0xf8, 0x78, + 0x7c, 0xb0, 0xe9, 0x8b, 0x74, 0x6f, 0xe1, 0xd5, 0x86, 0x0f, 0x93, 0x50, 0x98, 0x1c, 0x64, 0xf7, + 0x1b, 0xc2, 0xe1, 0x10, 0xd4, 0xd0, 0x8c, 0xaa, 0x3d, 0xf9, 0xbc, 0x92, 0xe5, 0xfe, 0x0b, 0xfe, + 0x56, 0x5e, 0xaa, 0xfb, 0x1a, 0x5f, 0x2f, 0xe5, 0xbb, 0x4a, 0x82, 0xad, 0x85, 0xe7, 0x7b, 0x4b, + 0x83, 0x9d, 0x76, 0xc2, 0xae, 0x04, 0x9b, 0x21, 0xbc, 0xf6, 0x29, 0xf1, 0xa2, 0x38, 0xc3, 0xd1, + 0x45, 0xb9, 0x13, 0xf7, 0x5a, 0x32, 0x95, 0x5a, 0xa5, 0xd6, 0x49, 0x2e, 0x30, 0xbf, 0x0a, 0x6f, + 0xe3, 0xc5, 0xd2, 0xef, 0x99, 0x59, 0x2e, 0xb3, 0xb3, 0x17, 0x83, 0x9f, 0x73, 0x78, 0x7e, 0x08, + 0x2a, 0xfc, 0x8a, 0xf0, 0xf2, 0xb9, 0x23, 0x7a, 0xd8, 0xae, 0x93, 0xc6, 0x1f, 0x8d, 0x1e, 0x5f, + 0x29, 0x7e, 0xda, 0xd4, 0xf7, 0xfa, 0xf2, 0x34, 0x4e, 0xe3, 0x51, 0x6b, 0x74, 0x83, 0x10, 0x3d, + 0xb9, 0x2a, 0xe1, 0xc4, 0x2f, 0xba, 0xf6, 0xe1, 0xf8, 0x60, 0x13, 0xed, 0x8e, 0x0e, 0x27, 0x31, + 0x3a, 0x9a, 0xc4, 0xe8, 0xcf, 0x24, 0x46, 0x5f, 0xa6, 0x71, 0x70, 0x34, 0x8d, 0x83, 0x5f, 0xd3, + 0x38, 0x78, 0xf5, 0x54, 0x69, 0x9b, 0x56, 0x09, 0x11, 0x26, 0xa3, 0x7e, 0xb4, 0x74, 0x22, 0xfa, + 0xca, 0xd0, 0xf1, 0x03, 0x9a, 0x39, 0x2a, 0xd4, 0x63, 0x05, 0x74, 0xb0, 0xdd, 0x3f, 0x93, 0xe8, + 0x9f, 0x9f, 0x28, 0xbb, 0x5f, 0x48, 0x48, 0x3a, 0x6e, 0xa0, 0xee, 0xfe, 0x0d, 0x00, 0x00, 0xff, + 0xff, 0xd3, 0x2f, 0xef, 0x8d, 0x1f, 0x04, 0x00, 0x00, } // Reference imports to suppress errors if they are not otherwise used. @@ -846,7 +846,7 @@ func (m *MsgModuleQuerySafe) Unmarshal(dAtA []byte) error { if postIndex > l { return io.ErrUnexpectedEOF } - m.Requests = append(m.Requests, &QueryRequest{}) + m.Requests = append(m.Requests, QueryRequest{}) if err := m.Requests[len(m.Requests)-1].Unmarshal(dAtA[iNdEx:postIndex]); err != nil { return err } diff --git a/proto/ibc/applications/interchain_accounts/host/v1/tx.proto b/proto/ibc/applications/interchain_accounts/host/v1/tx.proto index 22e8c9b3567..29cdb088c8f 100644 --- a/proto/ibc/applications/interchain_accounts/host/v1/tx.proto +++ b/proto/ibc/applications/interchain_accounts/host/v1/tx.proto @@ -47,7 +47,7 @@ message MsgModuleQuerySafe { string signer = 1; // requests defines the module safe queries to execute. - repeated QueryRequest requests = 2; + repeated QueryRequest requests = 2 [(gogoproto.nullable) = false]; } // MsgModuleQuerySafeResponse defines the response for Msg/ModuleQuerySafe