From 079a3ea2333f5a40a2bcda7936d88630e1ba1cd3 Mon Sep 17 00:00:00 2001 From: Dev Ojha Date: Wed, 1 May 2024 15:24:06 -0700 Subject: [PATCH] Remove log messages --- modules/core/keeper/msg_server.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/modules/core/keeper/msg_server.go b/modules/core/keeper/msg_server.go index eb8848c1bc3..2c43dd11944 100644 --- a/modules/core/keeper/msg_server.go +++ b/modules/core/keeper/msg_server.go @@ -536,14 +536,12 @@ func (k *Keeper) RecvPacketCheckNonRedundant(goCtx context.Context, msg *channel // Lookup module by channel capability module, capability, err := k.ChannelKeeper.LookupModuleByChannel(ctx, msg.Packet.DestinationPort, msg.Packet.DestinationChannel) if err != nil { - ctx.Logger().Error("receive packet failed", "port-id", msg.Packet.SourcePort, "channel-id", msg.Packet.SourceChannel, "error", errorsmod.Wrap(err, "could not retrieve module from port-id")) return false, errorsmod.Wrap(err, "could not retrieve module from port-id") } // Retrieve callbacks from router _, ok := k.PortKeeper.Route(module) if !ok { - ctx.Logger().Error("receive packet failed", "port-id", msg.Packet.SourcePort, "error", errorsmod.Wrapf(porttypes.ErrInvalidRoute, "route not found to module: %s", module)) return false, errorsmod.Wrapf(porttypes.ErrInvalidRoute, "route not found to module: %s", module) } @@ -552,18 +550,15 @@ func (k *Keeper) RecvPacketCheckNonRedundant(goCtx context.Context, msg *channel // If the packet was already received, perform a no-op // Use a cached context to prevent accidental state changes cacheCtx, writeFn := ctx.CacheContext() - // TODO: Update RecvPacket to skip cryptographic checks on Recheck. + // TODO: Update RecvPacket to skip MT inclusion checks on Recheck. err = k.ChannelKeeper.RecvPacket(cacheCtx, capability, msg.Packet, msg.ProofCommitment, msg.ProofHeight) switch err { case nil: writeFn() case channeltypes.ErrNoOpMsg: - // no-ops do not need event emission as they will be ignored - ctx.Logger().Debug("no-op on redundant relay", "port-id", msg.Packet.SourcePort, "channel-id", msg.Packet.SourceChannel) return true, nil default: - ctx.Logger().Error("receive packet failed", "port-id", msg.Packet.SourcePort, "channel-id", msg.Packet.SourceChannel, "error", errorsmod.Wrap(err, "receive packet verification failed")) return false, errorsmod.Wrap(err, "receive packet verification failed") } return false, nil