From 0468e3c529a2209cc6a3815666eea064dff3c23f Mon Sep 17 00:00:00 2001 From: Aditya Sripal <14364734+AdityaSripal@users.noreply.github.com> Date: Mon, 9 Dec 2024 17:12:09 +0100 Subject: [PATCH] remove unnecessary code --- modules/apps/transfer/v2/ibc_module.go | 2 +- modules/core/04-channel/v2/types/packet.go | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/modules/apps/transfer/v2/ibc_module.go b/modules/apps/transfer/v2/ibc_module.go index fb5816ea420..d1c5014e408 100644 --- a/modules/apps/transfer/v2/ibc_module.go +++ b/modules/apps/transfer/v2/ibc_module.go @@ -115,7 +115,7 @@ func (im *IBCModule) OnTimeoutPacket(ctx context.Context, sourceChannel string, func (im *IBCModule) OnAcknowledgementPacket(ctx context.Context, sourceChannel string, destinationChannel string, sequence uint64, recvSuccess bool, acknowledgement []byte, payload types.Payload, relayer sdk.AccAddress) error { var ack channeltypes.Acknowledgement - if err := transfertypes.ModuleCdc.UnmarshalJSON(acknowledgement, &ack); err != nil && recvSuccess { + if err := transfertypes.ModuleCdc.UnmarshalJSON(acknowledgement, &ack); err != nil { return errorsmod.Wrapf(ibcerrors.ErrUnknownRequest, "cannot unmarshal ICS-20 transfer packet acknowledgement: %v", err) } diff --git a/modules/core/04-channel/v2/types/packet.go b/modules/core/04-channel/v2/types/packet.go index aaad88762a7..1ba7722b925 100644 --- a/modules/core/04-channel/v2/types/packet.go +++ b/modules/core/04-channel/v2/types/packet.go @@ -9,10 +9,6 @@ import ( host "github.com/cosmos/ibc-go/v9/modules/core/24-host" ) -var ( - SentinelAcknowledgement = []byte{byte(1)} -) - // NewPacket constructs a new packet. func NewPacket(sequence uint64, sourceChannel, destinationChannel string, timeoutTimestamp uint64, payloads ...Payload) Packet { return Packet{