Optimize node encoding/decoding with stream-vbyte format #673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a node storage format change, need to migrate database, but I guess it's ok in light of new node key format, we'll need to migrate anyway, the same technique can be applied to new node key format as well.
The improvement is pretty good, we don't even use the SIMP optimizations, since we don't have that much integers.
Downside:
math.MaxUint32
.(((1<<32)-1) * 2) / 3600/24/365 = 272
, it means it takes 272 years for the version number to overflowuint32
, we are using 6 seconds block time right now, which makes it even longer.Benchmark
Compare with this version where I adjusted the test cases the same as this PR: