From f36b65856523411350e8c3c6f7335ab6ec0e2765 Mon Sep 17 00:00:00 2001 From: captain-kark Date: Tue, 1 Oct 2019 14:14:40 +0200 Subject: [PATCH 1/3] Include a reminder to unset LDFLAGS before running 'make install' --- docs/installation.md | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/docs/installation.md b/docs/installation.md index e550774cec5..cb96d036b2f 100644 --- a/docs/installation.md +++ b/docs/installation.md @@ -31,7 +31,23 @@ git clone -b https://github.com/cosmos/gaia cd gaia && make install ``` -> _NOTE_: If you have issues at this step, please check that you have the latest stable version of GO installed. +If this command fails due to the following error message, you might have already set `LDFLAGS` prior to running this step. + +``` +# github.com/cosmos/gaia/cmd/gaiad +flag provided but not defined: -L/usr/local/opt/foo +usage: link [options] main.o +... +make: *** [install] Error 2 +``` + +Unset this environment variable and try again. + +``` +LDFLAGS="" make install +``` + +> _NOTE_: If you still have issues at this step, please check that you have the latest stable version of GO installed. That will install the `gaiad` and `gaiacli` binaries. Verify that everything is OK: From 59407852f031106b02e91ff6fe4df21e7cf362f7 Mon Sep 17 00:00:00 2001 From: captain-kark Date: Tue, 1 Oct 2019 14:17:39 +0200 Subject: [PATCH 2/3] Fix CONTRIBUTING.md link to PR targeting instructions --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 24eb3aae1fc..0f6760e8bc8 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,10 +1,10 @@ -- Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/gaia/blob/develop/CONTRIBUTING.md#pr-targeting)) +- Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/gaia/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to github-issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote tests From a32f021f01901db0817599be031b436e075d9500 Mon Sep 17 00:00:00 2001 From: captain-kark Date: Tue, 1 Oct 2019 15:25:12 +0200 Subject: [PATCH 3/3] Remove placeholder LDFLAGS value from example error output --- docs/installation.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/installation.md b/docs/installation.md index cb96d036b2f..39602e11666 100644 --- a/docs/installation.md +++ b/docs/installation.md @@ -35,7 +35,7 @@ If this command fails due to the following error message, you might have already ``` # github.com/cosmos/gaia/cmd/gaiad -flag provided but not defined: -L/usr/local/opt/foo +flag provided but not defined: -L usage: link [options] main.o ... make: *** [install] Error 2