Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPIC: Refactor to SDK v0.47 and IBC v7 #2540

Closed
7 tasks done
Tracked by #2790
glnro opened this issue May 25, 2023 · 0 comments · Fixed by #2852
Closed
7 tasks done
Tracked by #2790

EPIC: Refactor to SDK v0.47 and IBC v7 #2540

glnro opened this issue May 25, 2023 · 0 comments · Fixed by #2852
Assignees
@sainoe @MSalopek
Labels
admin: epic An EPIC -- meta issue used to track a body of work admin: key-result A key result (in the context of OKRs) S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates)

Comments

@glnro
Copy link
Contributor

glnro commented May 25, 2023 •
edited by mpoke
Loading

Description

Background

As of September 2022, Gaia was prepared to upgrade to SDK v0.46 and IBC v5. In order to accomodate Interchain-Security (ICS) which had been built on v0.45 of the SDK, the work to update Gaia was reverted, and the application subsequently downgraded to SDK v0.45 and IBC v3. As SDK v0.45 is only being maintained for security patches and IBC v4 will be EOL by August 2023, is it imperative that Gaia upgrade to the latest stable SDK and IBC versions.

Major Dependencies

In addition to the SDK and IBC, several other major dependencies include CometBFT, ICS, and Packet-Forward-Middleware (PFM). While Comet has a major compatible version released, the remaining dependencies have yet to cut a major release with SDK v0.47, IBC v7, and Comet v0.37. At the time of writing, ICS and PFM dependencies are leveraging commits from a feature branch and main respectively.

Internal Module Dependencies

The only proprietary module that Gaia has is x/globalfee. This module will also need to be updated to be compatible with SDK v0.47.

Testing

In addition to ensuring existing unit, sim and e2e tests are functioning, additional test cases will need to be written to ensure regressions have not been introduced. For e2e this will include additional tests for the new gov api. For app wiring, this should at minimum include guarantees for partial ordering of modules (ie where the staking module needs to come before the provider module), that expected keepers are instantiated.

Target Branch

The canonical feature branch for this work is feat/sdk-47-ibc-7

Epics

Must have
Preview Give feedback
  1. Refactor App Wiring for SDK v0.47 & IBC v7 #2533
    type: feature-request
    sainoe
  2. Refactor Globalfee for SDK v0.47 #2534
    dependencies
    sainoe
  3. Prepare Hub Upgrade for SDK v0.47 & IBC v7 #2535
    sdk-v0.47 type: feature-request
  4. Refactor E2E Tests for SDK v0.47 & IBC v7 #2536
    19 of 22
    S: KTLO dependencies scope: testing
    sainoe
  5. update docs after upgrading to cosmos-sdk v47 and ibc-go v7 #2537
    7 of 7
    S: KTLO dependencies scope: docs type: tech-debt
    MSalopek
  6. Refactor ICS for SDK v0.47 & IBC v7 #2574
    MSalopek

Nice to have
Preview Give feedback
  1. regression Test SDK v0.47 & IBC v7 upgrade #2538
    S: KTLO scope: testing
    MSalopek
@glnro glnro added admin: epic An EPIC -- meta issue used to track a body of work status: waiting-triage This issue/PR has not yet been triaged by the team. labels May 25, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub May 25, 2023
@glnro glnro mentioned this issue May 25, 2023
Merged
18 tasks
@mpoke mpoke added admin: key-result A key result (in the context of OKRs) and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels May 25, 2023
@mpoke mpoke moved this from 🩹 Triage to 🏗 In progress in Cosmos Hub May 25, 2023
@sainoe sainoe self-assigned this Jun 2, 2023
@mpoke mpoke mentioned this issue Jun 28, 2023
Closed
@mpoke mpoke pinned this issue Jun 28, 2023
@mpoke mpoke moved this from 🏗 F3: InProgress to 🛑 F3: OnHold in Cosmos Hub Aug 31, 2023
This was referenced Sep 14, 2023
Closed
Closed
Closed
Closed
@mpoke mpoke added the S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) label Sep 15, 2023
@mpoke mpoke moved this from 🛑 F3: OnHold to 🏗 F3: InProgress in Cosmos Hub Sep 15, 2023
@sainoe sainoe moved this from 🏗 F3: InProgress to 👍 F4: Assessment in Cosmos Hub Sep 26, 2023
@sainoe sainoe moved this from 👍 F4: Assessment to 🏗 F3: InProgress in Cosmos Hub Sep 26, 2023
@sainoe sainoe moved this from 🏗 F3: InProgress to 👍 F4: Assessment in Cosmos Hub Oct 3, 2023
@mpoke mpoke mentioned this issue Nov 6, 2023
Closed
@mpoke mpoke moved this from 👍 F4: Assessment to 🏗 F3: InProgress in Cosmos Hub Nov 16, 2023
@mpoke mpoke closed this as completed Nov 16, 2023
@github-project-automation github-project-automation bot moved this from 🏗 F3: InProgress to 👍 F4: Assessment in Cosmos Hub Nov 16, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Nov 16, 2023
@MSalopek MSalopek mentioned this issue Dec 12, 2023
Merged
8 tasks
@mpoke mpoke unpinned this issue Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sainoe sainoe

@MSalopek MSalopek

Labels
admin: epic An EPIC -- meta issue used to track a body of work admin: key-result A key result (in the context of OKRs) S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates)
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps!: bring cosmos-sdk v47 deps to gaia (ibc-go, ics, pfm) cosmos/gaia
4 participants
@glnro @mpoke @sainoe @MSalopek