Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cosmos/ledger-go after #4 merged #1576

Closed
5 tasks
okwme opened this issue Jul 6, 2022 · 3 comments · Fixed by #1634
Closed
5 tasks

update cosmos/ledger-go after #4 merged #1576

okwme opened this issue Jul 6, 2022 · 3 comments · Fixed by #1634

Comments

@okwme
Copy link
Contributor

okwme commented Jul 6, 2022

Summary of Bug

after temp fix in #1575 we should make permanent fix once cosmos/ledger-go#4 is merged

Version

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Jul 21, 2022

#4 was just merged. Do we need to wait for it to cut a release before we could make a PR for this (I would be happy to update this, test it and make a PR)?

@okwme
Copy link
Contributor Author

okwme commented Jul 25, 2022

great to hear!
i've just asked in the PR whether there will be a release or not, their last one wasn't since 2019.
would be amazing if you were able to update, test and make a new PR based on their reply @bjaanes thank you so much for the contribution!

@gjermundgaraba
Copy link
Contributor

I just saw 0.9.3 was cut, so I created a PR to update that. Let me know if want any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants