Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

merge pr #721 #864

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

freddyli7
Copy link
Contributor

Closes: #721

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@freddyli7 freddyli7 merged commit 57b7f26 into freddy/stargate-integration-fix Apr 15, 2021
@freddyli7 freddyli7 deleted the freddy/stargate-721 branch April 15, 2021 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant