Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

return 0x0 as extra data in block instead of nil #333

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Conversation

noot
Copy link
Contributor

@noot noot commented Jun 16, 2020

Closes #306 closes #301

Description

  • return 0x0 as extra data instead of nil for eth.getBlock()
  • update rpc tests for getBlock

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@noot noot self-assigned this Jun 16, 2020
@noot noot requested a review from fedekunze June 16, 2020 21:51
@fedekunze fedekunze merged commit 94f6acc into development Jun 17, 2020
@fedekunze fedekunze deleted the noot/fixes branch June 17, 2020 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot get eth.getBlock for block 1 test eth_getBlockByHash
2 participants