This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 161
PRECISION LOSS of account balance in evm module export #621
Comments
thanks for the bug report. Will look into it 👍 |
looks like it's not a bug but just a format mismatch |
In my own opinion, there will be a deflation or inflation of account in evm module when u import the exported genesis file. The total supply of evm native coin is going to be unpredictable. I prefer to use sdk.Int instead of big.Int in GenesisAccount.Balance and have made a local branch that fixed this problem. I am willing to push a PR if you need it. Expected for ur better solution on this. |
Yeah I opened a PR with the same approach: #623 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
System info: [Include Ethermint commit, operating system name, and other relevant details]
NOTE:Works on the bug fix branch
fedekunze/617-fix-export
commit:8165a448
operating system:macOS Catalina 10.15.6
go version:go1.15.2 darwin/amd64
Steps to reproduce:
Precision loss:
![image](https://user-images.githubusercontent.com/46394603/100336430-2350b080-3011-11eb-850f-1ff719c1f4d7.png)
Expected behavior: [What you expected to happen]
It's expected to keep consistent between the balances in both evm and auth.
Actual behavior: [What actually happened]
Additional info: [Include gist of relevant config, logs, etc.]
The text was updated successfully, but these errors were encountered: