This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Allow networkId as a parameter #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow setting network id
adrianbrink
force-pushed
the
allow_network_id
branch
from
4d74cb8 to
d7d8ed3
Compare
|
i-norden
pushed a commit
to vulcanize/old_ethermint
that referenced
this pull request
Aug 31, 2020
* add EnsureExists check to GetTransactionCount * cleanup, return 0 as nonce if account doesn't exist * update changelog * update changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from #324
Fixes #214
Related to #81
Metamask was not taking in consideration networkId until recent updates. Its related to EIP ethereum/EIPs#155 & MetaMask/metamask-extension#1722 (comment)