-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove migration scripts <=0.38 #9291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:x/auth
C:x/bank
C:x/distribution
distribution module related
C:x/genutil
genutil module issues
C:x/gov
C:x/staking
labels
May 10, 2021
amaury1093
commented
May 10, 2021
amaury1093
force-pushed
the
am/9218-remove-legacy
branch
from
May 10, 2021 12:39
3deb068
to
e0c4df5
Compare
…s-sdk into am/9218-remove-legacy
amaury1093
removed
C:x/auth
C:x/bank
C:x/distribution
distribution module related
C:x/gov
C:x/staking
labels
May 10, 2021
github-actions
bot
added
C:x/auth
C:x/bank
C:x/distribution
distribution module related
C:x/gov
C:x/staking
labels
May 10, 2021
amaury1093
removed
C:x/distribution
distribution module related
C:x/evidence
C:x/gov
C:x/params
C:x/staking
C:x/upgrade
labels
May 11, 2021
robert-zaremba
approved these changes
May 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, great to remove legacy things!
amaury1093
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
May 11, 2021
github-actions
bot
added
C:x/auth
C:x/bank
C:x/distribution
distribution module related
C:x/evidence
C:x/gov
C:x/params
C:x/staking
C:x/upgrade
labels
May 11, 2021
cyberbono3
approved these changes
May 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
elise-ng
added a commit
to elise-ng/likecoin-chain
that referenced
this pull request
Feb 10, 2022
Ref oursky#20 Reverts likecoin@b761463 This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291 Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
hochiw
pushed a commit
to hochiw/likecoin-chain
that referenced
this pull request
Feb 11, 2022
Ref oursky#20 Reverts likecoin@b761463 This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291 Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
elise-ng
added a commit
to elise-ng/likecoin-chain
that referenced
this pull request
Feb 21, 2022
Ref oursky#20 Reverts likecoin@b761463 This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291 Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
elise-ng
added a commit
to oursky/likecoin-chain
that referenced
this pull request
Feb 21, 2022
Ref #20 Reverts likecoin@b761463 This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291 Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
rickmak
pushed a commit
to oursky/likecoin-chain
that referenced
this pull request
Feb 21, 2022
Ref #20 Reverts likecoin@b761463 This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291 Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
elise-ng
added a commit
to oursky/likecoin-chain
that referenced
this pull request
Mar 14, 2022
Ref #20 Reverts likecoin@b761463 This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291 Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
elise-ng
added a commit
to oursky/likecoin-chain
that referenced
this pull request
Mar 25, 2022
Ref #20 Reverts likecoin@b761463 This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291 Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
elise-ng
added a commit
to oursky/likecoin-chain
that referenced
this pull request
Mar 29, 2022
Ref #20 Reverts likecoin@b761463 This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291 Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
elise-ng
added a commit
to oursky/likecoin-chain
that referenced
this pull request
Apr 4, 2022
Ref #20 Reverts likecoin@b761463 This migration depended on `github.com/cosmos/cosmos-sdk/x/genutil/legacy/v038` module which is already removed from upstream, ref: cosmos/cosmos-sdk#9291 Removing this for now; If we need to keep it, will have to resolve `v038` from an older sdk fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:automerge
Automatically merge PR once all prerequisites pass.
C:CLI
C:x/auth
C:x/bank
C:x/distribution
distribution module related
C:x/evidence
C:x/genutil
genutil module issues
C:x/gov
C:x/params
C:x/staking
C:x/upgrade
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Legacy migrations came up during v043 audit #9218. This PR removes all legacy migration scripts <=0.38.
closes #9269
closes #8678
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes