[Bugfix] Gov Deposits Querier (Initial Deposit) #8813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8813 +/- ##
==========================================
- Coverage 59.37% 59.30% -0.08%
==========================================
Files 563 563
Lines 31270 31306 +36
==========================================
- Hits 18566 18565 -1
- Misses 10546 10583 +37
Partials 2158 2158
|
alessio
reviewed
Mar 9, 2021
alessio
reviewed
Mar 10, 2021
amaury1093
reviewed
Mar 16, 2021
| } | ||
| } | ||
|
|
||
| return types.Deposit{}, fmt.Errorf("failed to find the initial deposit for proposalID %d", proposalID) |
There was a problem hiding this comment.
could you use sdkerrors.Wrapf here?
alexanderbez
approved these changes
Mar 16, 2021
|
@YunSuk-Yeo Any update on tests and fixing merge conflicts here? |
|
@YunSuk-Yeo any news? Or else someone on the SDK team could copy the PR and fix the conflicts? |
9 tasks
|
With no response, we are forking this branch and adding tests: #9288 |
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #8758
Deposits querier must include initial deposit by querying submit proposal
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes