Add packet_connection attribute to packet lifecycle methods

[ethanfrey]

Closes #8445

Please backport to 0.41.x branch if merged to master (non-consensus breaking, as events are not in any header hash)

Description

closes: #XXXX

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[ethanfrey]

I was going to fix the failing CI test, only to find this:

--- FAIL: TestIntegrationTestSuite (0.08s)
    cli_test.go:26: setting up integration test suite
    network.go:171: acquiring test network lock
    network.go:176: created temporary directory: /tmp/TestIntegrationTestSuite793956338/001/chain-mDcgho584935081
    network.go:185: preparing test network...
    network.go:372: starting test network...
    network.go:374: 
        	Error Trace:	network.go:374
        	            				cli_test.go:32
        	            				suite.go:118
        	            				cli_test.go:86
        	Error:      	Received unexpected error:
        	            	listen tcp 0.0.0.0:45819: bind: address already in use
        	Test:       	TestIntegrationTestSuite
FAIL

I assume this is an issue in the CI and just should be re-run?

[colin-axner]

ACK

[colin-axner]

@ethanfrey could you add a changelog as well?

[ethanfrey]

Good point. I will add that

[AdityaSripal]

ACK

[codecov]

Codecov Report

Merging #8458 (71e34d5) into master (896eee2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #8458   +/-   ##
=======================================
  Coverage   61.50%   61.51%           
=======================================
  Files         650      650           
  Lines       37234    37238    +4     
=======================================
+ Hits        22902    22906    +4     
  Misses      11929    11929           
  Partials     2403     2403           

Impacted Files	Coverage Δ
x/ibc/core/04-channel/keeper/packet.go	95.30% <100.00%> (+0.06%)	⬆️

[colin-axner]

fyi @ethanfrey this pr has to be up to date on master in order to be merged and we don't have perms to update your branch

[ethanfrey]

Just rebased.

I'd be more than happy to allow you to push but cannot find the setting (i have tried before)

[colin-axner]

Well it looks like tests are blocked on #8475. Let's check back in monday and see if we can get it merged then. I will backport it

[ethanfrey]

Thank you. Ping me Monday when you are ready and I can rebase again as needed.

[colin-axner]

@ethanfrey looks like tests are working again if you could rebase (there also might be a button you can click on the right of this pr that allows edits from maintainers?)

[ethanfrey]

Just rebased again.

I have checked and no button to allow commits from maintainers. I have tried this before. There must be some hidden account setting where no one can edit any of my PRs.