Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inconsistent flag names in upgrade proposal command #7697

Merged
merged 3 commits into from
Oct 28, 2020
Merged

fix inconsistent flag names in upgrade proposal command #7697

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8ff0d9
fix inconsistent flag names in upgrade proposal command
yihuang Oct 28, 2020
55b7d17
Merge branch 'master' into upgrade-flags
mergify[bot] Oct 28, 2020
216922a
Merge branch 'master' into upgrade-flags
mergify[bot] Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

* (x/staking) [\#7499](https://github.com/cosmos/cosmos-sdk/pull/7499) `BondStatus` is now a protobuf `enum` instead of an `int32`, and JSON serialized using its protobuf name, so expect names like `BOND_STATUS_UNBONDING` as opposed to `Unbonding`.
* (x/evidence) [\#7538](https://github.com/cosmos/cosmos-sdk/pull/7538) The ABCI's `Result.Data` field of `MsgSubmitEvidence` does not contain the raw evidence's hash, but the encoded `MsgSubmitEvidenceResponse` struct.
* (x/upgrade) [#7697](https://github.com/cosmos/cosmos-sdk/pull/7697) Rename flag name "--time" to "--upgrade-time", "--info" to "--upgrade-info", to keep it consistent with help message.

### API Breaking

Expand Down
4 changes: 2 additions & 2 deletions x/upgrade/client/cli/tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ const (
TimeFormat = "2006-01-02T15:04:05Z"

FlagUpgradeHeight = "upgrade-height"
FlagUpgradeTime = "time"
FlagUpgradeInfo = "info"
FlagUpgradeTime = "upgrade-time"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, yet why not just changing update-height to height? Considering that the command itself is named software-upgrade, flags upgrade- prefix has always sounded a bit of an unnecessary repetition IMHO

Copy link
Collaborator Author

@yihuang yihuang Oct 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--height might be confusing with other usage? when query stuff, there's usually a block height parameter.

Copy link
Contributor

@alessio alessio Oct 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--height is a flag for query commands only. It should be safe to reuse it here - please check it out in client/flags 👍

FlagUpgradeInfo = "upgrade-info"
)

// GetTxCmd returns the transaction commands for this module
Expand Down