Add Fee granter field #7418
Merged
Add Fee granter field #7418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7418 +/- ##
==========================================
+ Coverage 55.23% 55.24% +0.01%
==========================================
Files 590 591 +1
Lines 36914 36932 +18
==========================================
+ Hits 20390 20404 +14
- Misses 14420 14422 +2
- Partials 2104 2106 +2 |
…ronc/fee-granter-field
…ronc/fee-granter-field
…ronc/fee-granter-field
amaury1093
reviewed
Oct 2, 2020
ethanfrey
approved these changes
Oct 2, 2020
aaronc
requested review from
robert-zaremba,
amaury1093,
anilcse,
blushi and
clevinson
anilcse
approved these changes
Oct 5, 2020
Comment on lines
+71
to
+72
| feeGranter := tx.FeeGranter() | ||
| require.Empty(t, feeGranter) |
There was a problem hiding this comment.
Suggested change
| feeGranter := tx.FeeGranter() | |
| require.Empty(t, feeGranter) | |
| require.Empty(t, tx.FeeGranter()) |
ethanfrey
approved these changes
Oct 5, 2020
| // RejectFeeGranterDecorator is a placeholder AnteDecorator for fee grants for | ||
| // when that functionality is enabled. Currently it simpy rejects transactions | ||
| // which have the Fee.granter field set. | ||
| // RejectFeeGranterDecorator is an AnteDecorator which rejects transactions which |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on https://github.com/cosmos/cosmos-sdk/pull/7384/files#r495258961, this adds the a
granterfield tocosmos.tx.v1beta1.Feein preparation for fee grants (#7106, #5768, #7074).For now, it just rejects transactions with
granterset and serves as a placeholder for this functionality in the future.Adding the
granterfield now has the benefit of preventing spurious unknown field rejections for future protobuf clients which unnecessarily encode default values, as well as clearer error messages.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes