WIP: Add x/msg_authorization module
#7370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atheeshp
changed the title
x/authorization modulex/authorization module
Codecov Report
@@ Coverage Diff @@
## master #7370 +/- ##
==========================================
- Coverage 54.21% 54.14% -0.07%
==========================================
Files 611 631 +20
Lines 38464 39291 +827
==========================================
+ Hits 20852 21276 +424
- Misses 15503 15864 +361
- Partials 2109 2151 +42 |
anilcse
changed the title
x/authorization modulex/msg_authorization module
…into aleem/msg_authorization
…into aleem/msg_authorization
amaury1093
reviewed
Oct 2, 2020
| @@ -0,0 +1,130 @@ | |||
| package keeper | |||
There was a problem hiding this comment.
I believe having an internal folder was the old way of writing modules. Let's stick to having keeper at the root folder of the module
aaronc
requested changes
Oct 2, 2020
| } | ||
| granter := signers[0] | ||
| if !bytes.Equal(granter, grantee) { | ||
| authorization, _ := k.GetAuthorization(ctx, grantee, granter, msg.Type()) |
There was a problem hiding this comment.
I'll need to update the ADR draft but we should use proto.MessageName(msg) now instead of msg.Type()
…eem/msg_authorization
…into aleem/msg_authorization # Conflicts: # x/msg_authorization/keeper/keeper.go # x/msg_authorization/keeper/keeper_test.go # x/msg_authorization/types/msgs.go
|
This pull request introduces 2 alerts when merging cf097d4 into 332d8ec - view on LGTM.com new alerts:
|
6 tasks
11 tasks
aaronc
reviewed
Nov 23, 2020
| @@ -0,0 +1,12 @@ | |||
| syntax = "proto3"; | |||
| package cosmos.msg_authorization.v1beta1; | |||
There was a problem hiding this comment.
Suggested change
| package cosmos.msg_authorization.v1beta1; | |
| package cosmos.authz.v1beta1; |
aaronc
reviewed
Nov 23, 2020
| @@ -0,0 +1,46 @@ | |||
| package msg_authorization | |||
There was a problem hiding this comment.
Suggested change
| package msg_authorization | |
| package authz |
|
closing this PR in favour of #7629 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5412
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes