Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hybrid codec usage #6843

Merged
merged 11 commits into from
Jul 25, 2020
Merged

Remove hybrid codec usage #6843

merged 11 commits into from
Jul 25, 2020

Conversation

anilcse
Copy link
Collaborator

@anilcse anilcse commented Jul 24, 2020

Description

ref: #6837


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #6843 into master will increase coverage by 5.85%.
The diff coverage is 60.77%.

@@            Coverage Diff             @@
##           master    #6843      +/-   ##
==========================================
+ Coverage   55.60%   61.45%   +5.85%     
==========================================
  Files         457      508      +51     
  Lines       27440    31461    +4021     
==========================================
+ Hits        15257    19335    +4078     
+ Misses      11083    10623     -460     
- Partials     1100     1503     +403     

@anilcse anilcse marked this pull request as ready for review July 24, 2020 21:44
@aaronc aaronc mentioned this pull request Jul 24, 2020
16 tasks
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed a small issue with evidence JSON.

Otherwise lgtm. Thanks @anilcse !

x/evidence/keeper/keeper.go Outdated Show resolved Hide resolved
x/evidence/keeper/keeper.go Outdated Show resolved Hide resolved
x/ibc/03-connection/keeper/keeper.go Outdated Show resolved Hide resolved
@aaronc aaronc changed the title Remove hybrid codec Remove hybrid codec usage Jul 24, 2020
@anilcse anilcse requested a review from aaronc July 24, 2020 23:56
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mergify mergify bot merged commit 3bafd82 into master Jul 25, 2020
@mergify mergify bot deleted the anil/6837-remove-hybrid-codec branch July 25, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants