x/bank: Refactor CLI & Tests

[alexanderbez]

Description

• Remove Indent from client logic (should have never existed -- sorry should be separate PR)
• Add TxGenerator, Marshaler and AccountRetriever to testutil.Config
• Refactor x/bank CLI handlers and tests
• New NewFactoryCLI (NewFactoryFrom needs to be removed)
• New GenerateOrBroadcastTxCLI (GenerateOrBroadcastTx needs to be removed)

ref: #6423

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

[codecov]

Codecov Report

Merging #6525 into master will increase coverage by 1.21%.
The diff coverage is 63.28%.

@@            Coverage Diff             @@
##           master    #6525      +/-   ##
==========================================
+ Coverage   55.60%   56.81%   +1.21%     
==========================================
  Files         457      481      +24     
  Lines       27440    28935    +1495     
==========================================
+ Hits        15257    16439    +1182     
- Misses      11083    11328     +245     
- Partials     1100     1168      +68     

[alexanderbez]

This returns an sdk.Coin, which matches the querier behavior and other queries similar to this.

[aaronc]

Have you verified that setting node, keyring, etc. from the config file still works with these changes? I imagine it still works from other cli methods but not bank query and tx because the standard New/Init which uses viper is no longer called there.

[alexanderbez]

It does not @aaronc which is a huge PIA. There is so much work to be done here. The CLI is such a cluster f#ck right now.

However, I think I can manage to keep the current flow while working on the new.

[alexanderbez]

@alessio, @aaronc et al. I ask you that review this under the following assumptions:

• Review (and accept) knowing integration-tests will fail.
  • Current CLI integration tests & fixtures need to be completely gutted (I'll do this in a followup PR).
• Current config.toml (client) will be removed entirely (which is a half-working pile of crap). I know this adds some convenience to users, but it can mask errors/problems. If we really wish to have this, we can add a new client stanza to the existing app.toml.

[tac0turtle]

🙈

[alexanderbez]

Don't worry -- we're in good hands. I can see the light at the end of the tunnel...

[aaronc]

@alessio, @aaronc et al. I ask you that review this under the following assumptions:

• Review (and accept) knowing integration-tests will fail.

  • Current CLI integration tests & fixtures need to be completely gutted (I'll do this in a followup PR).

• Current config.toml (client) will be removed entirely (which is a half-working pile of crap). I know this adds some convenience to users, but it can mask errors/problems. If we really wish to have this, we can add a new client stanza to the existing app.toml.

oh boy 🙈. anyway upward and onward! we'll make it happen.