Update TxBuilder to use SignatureV2 #6443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6443 +/- ##
==========================================
+ Coverage 55.74% 55.83% +0.09%
==========================================
Files 466 466
Lines 27890 27906 +16
==========================================
+ Hits 15546 15582 +36
+ Misses 11231 11210 -21
- Partials 1113 1114 +1 |
…ronc/6213-sig-v2-builder
aaronc
requested review from
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
fedekunze
reviewed
Jun 16, 2020
jgimeno
reviewed
Jun 16, 2020
fedekunze
approved these changes
Jun 16, 2020
| // StdTxBuilder wraps StdTx to implement to the context.TxBuilder interface | ||
| // StdTxBuilder wraps StdTx to implement to the context.TxBuilder interface. | ||
| // Note that this type just exists for backwards compatibility with amino StdTx | ||
| // and will not work for protobuf transactions. |
There was a problem hiding this comment.
This file has low coverage and we should prob add unit tests on another PR
There was a problem hiding this comment.
I agree we should cover it better. @anilcse let's coordinate on a PR to test TxBuilder implementations generically.
anilcse
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of several bite-size PR's that are being pulled out of #6216 to implement #6213.
This PR:
client.TxBuilderto useSignatureV2introduced in Add SignatureV2 infrastructure #6373sign-modecommand-line flagFeeTxandTxWithMemofromx/auth/antetotypesto deal with cyclic dependency issuesLegacyAminoJSONHandlerdirectly intox/auth/typesto avoid cyclic dependenciesBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer