-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CloseDB method from Keybase interface #5820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK -- I assume we didn't need this? Can you confirm @alessio ?
Correct, we don't need it @alexanderbez. It's a leftover dating back to the time when we hadn't yet implemented the lazy keybase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change should be mentioned in the API Breaking Changes
stanza; looks good otherwise
Codecov Report
@@ Coverage Diff @@
## master #5820 +/- ##
=======================================
Coverage 32.51% 32.51%
=======================================
Files 346 346
Lines 39016 39012 -4
=======================================
- Hits 12685 12684 -1
+ Misses 25064 25061 -3
Partials 1267 1267 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
There is no issue, was commented in a call with @alessio.
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)