Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience functions {,Must}Bech32ifyAddressBytes #5581

Merged
merged 2 commits into from
Jan 29, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jan 28, 2020

Per @jackzampolin's request.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio force-pushed the alessio/bech32ify-addresses branch from ceacf2e to e293ac9 Compare January 28, 2020 19:31
@alessio alessio marked this pull request as ready for review January 28, 2020 19:31
types/address_test.go Show resolved Hide resolved
types/address_test.go Show resolved Hide resolved
types/address_test.go Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix lint/CI, otherwise LGTM 👍

@alessio
Copy link
Contributor Author

alessio commented Jan 29, 2020

@alexanderbez last build was OK. golangci-lint seems happy too. The only failing job is proto

@alessio alessio requested a review from alexanderbez January 29, 2020 09:47
@alessio alessio dismissed alexanderbez’s stale review January 29, 2020 09:48

Fix all linter warnings. Build was fine except proto, which is unrelated. See my comment above #5581 (comment)

@alessio alessio merged commit deea89e into master Jan 29, 2020
@alessio alessio deleted the alessio/bech32ify-addresses branch January 29, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants