Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add msg_authorization module #5412

Conversation

sahith-narahari
Copy link
Contributor

@sahith-narahari sahith-narahari commented Dec 16, 2019

Closes: cosmos-cg-key-management#10

Description

This PR implements msg_authorization module as described in https://github.com/cosmos-cg-key-management/cosmos-sdk/blob/regen-network/msg-delegation-spec/docs/architecture/adr-013-msg-authorization.md


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

}

func (capability SendCapability) Accept(msg sdk.Msg, block abci.Header) (allow bool, updated Capability, delete bool) {
switch msg := msg.(type) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

singleCaseSwitch: should rewrite switch statement to if statement (from gocritic)

@lgtm-com
Copy link

lgtm-com bot commented Dec 16, 2019

This pull request introduces 1 alert when merging 2535465 into b04dcf2 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to field

@stale
Copy link

stale bot commented Jan 15, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 15, 2020
@sahith-narahari
Copy link
Contributor Author

This PR is blocked on #5491, will resume once protobuf implementation is merged to master

@stale stale bot removed the stale label Jan 16, 2020
@stale
Copy link

stale bot commented Mar 28, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 28, 2020
@sahith-narahari
Copy link
Contributor Author

Will resume this once tx client migration is done

@stale stale bot removed the stale label Mar 30, 2020
@clevinson clevinson added this to the v0.39 milestone Apr 30, 2020
@alexanderbez
Copy link
Contributor

@clevinson we may have to consider punting this 0.40. Thoughts @aaronc?

@aaronc
Copy link
Member

aaronc commented Jun 25, 2020

@clevinson we may have to consider punting this 0.40. Thoughts @aaronc?

Unfortunately we may need to...

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 6, 2020
@aaronc aaronc added pinned and removed stale labels Jul 6, 2020
@alexanderbez alexanderbez modified the milestones: v0.40 [Stargate], v0.41 Jul 21, 2020
@aaronc aaronc mentioned this pull request Aug 17, 2020
4 tasks
@sahith-narahari
Copy link
Contributor Author

Closing in favour of #7370

@ryanchristo ryanchristo deleted the regen-network/msg_authorization branch December 12, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Msg Authorization Module
6 participants