Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DefaultUnbondingTime parameter to 3 weeks #4712

Closed
wants to merge 1 commit into from

Conversation

ggomma
Copy link

@ggomma ggomma commented Jul 12, 2019

cosmos-sdk's default unbonding time is 3 weeks as used right now.
But the code is written as 3 days.
DefaultUnbondingTime time.Duration = time.Second * 60 * 60 * 24 * 3

It would be better to fix this line to 3weeks
DefaultUnbondingTime time.Duration = time.Second * 60 * 60 * 24 * 7 * 3

@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #4712 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4712      +/-   ##
==========================================
- Coverage   54.15%   54.14%   -0.02%     
==========================================
  Files         272      272              
  Lines       17349    17349              
==========================================
- Hits         9395     9393       -2     
- Misses       7271     7273       +2     
  Partials      683      683

1 similar comment
@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #4712 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4712      +/-   ##
==========================================
- Coverage   54.15%   54.14%   -0.02%     
==========================================
  Files         272      272              
  Lines       17349    17349              
==========================================
- Hits         9395     9393       -2     
- Misses       7271     7273       +2     
  Partials      683      683

@alessio alessio requested a review from cwgoes July 12, 2019 08:23
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, good catch on the comment discrepancy

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon this is worth a changelog entry - please the clog tool for such task: go get github.com/cosmos/tools/cmd/clog/

@fedekunze fedekunze added the R4R label Jul 15, 2019
@alexanderbez
Copy link
Contributor

Bump @ggomma 😄

Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add changelog entry though

@jackzampolin
Copy link
Member

Is this blocked on anything? We should go ahead and merge this.

@fedekunze
Copy link
Collaborator

let's open a new PR with the pending entry then

@fedekunze fedekunze mentioned this pull request Jul 31, 2019
5 tasks
@fedekunze
Copy link
Collaborator

Moved to #4823. Sorry @ggomma but we want to fix this for the next release candidate

@fedekunze fedekunze closed this Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants