-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DefaultUnbondingTime parameter to 3 weeks #4712
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4712 +/- ##
==========================================
- Coverage 54.15% 54.14% -0.02%
==========================================
Files 272 272
Lines 17349 17349
==========================================
- Hits 9395 9393 -2
- Misses 7271 7273 +2
Partials 683 683 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4712 +/- ##
==========================================
- Coverage 54.15% 54.14% -0.02%
==========================================
Files 272 272
Lines 17349 17349
==========================================
- Hits 9395 9393 -2
- Misses 7271 7273 +2
Partials 683 683 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, good catch on the comment discrepancy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reckon this is worth a changelog entry - please the clog
tool for such task: go get github.com/cosmos/tools/cmd/clog/
Bump @ggomma 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add changelog entry though
Is this blocked on anything? We should go ahead and merge this. |
let's open a new PR with the pending entry then |
cosmos-sdk's default unbonding time is 3 weeks as used right now.
But the code is written as 3 days.
DefaultUnbondingTime time.Duration = time.Second * 60 * 60 * 24 * 3
It would be better to fix this line to 3weeks
DefaultUnbondingTime time.Duration = time.Second * 60 * 60 * 24 * 7 * 3