R4R: CacheKVStore keep sorted items #4265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #4265 +/- ##
==========================================
+ Coverage 59.38% 59.46% +0.07%
==========================================
Files 214 214
Lines 14533 14569 +36
==========================================
+ Hits 8631 8664 +33
- Misses 5264 5267 +3
Partials 638 638 |
|
@mossid Why was this closed ? I benchmarked this on one of our state migrators and the improvement was very significant. |
|
@hendrikhofstadt the gaiasim test didnt show performance improvement, so I thought it didnt work. Turns out most of the execution time in gaiasim is of the golang memory manager. Reopening the pr. Thanks for testing, do you have a benchmark result? |
mossid
force-pushed
the
joon/2286-cachekv-sorted
branch
from
5cb6fe5 to
b40f995
Compare
mossid
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
mossid
changed the title
alessio
approved these changes
May 14, 2019
alexanderbez
approved these changes
May 15, 2019
There was a problem hiding this comment.
Nice work @mossid, thanks! I've added a pending log entry and also I added a benchmark suite. Although the benchmark suite doesn't add any new items, it just solely benchmarks the iterator. Still, amazing improvement by not sorting every time.
current master:
goos: darwin
goarch: amd64
pkg: github.com/cosmos/cosmos-sdk/store/cachekv
BenchmarkCacheKVStoreIterator500-4 100000 308614 ns/op
BenchmarkCacheKVStoreIterator1000-4 50000 629593 ns/op
BenchmarkCacheKVStoreIterator10000-4 2000 15185275 ns/op
BenchmarkCacheKVStoreIterator50000-4 500 75376816 ns/op
BenchmarkCacheKVStoreIterator100000-4 200 183787254 ns/op
this PR:
goos: darwin
goarch: amd64
pkg: github.com/cosmos/cosmos-sdk/store/cachekv
BenchmarkCacheKVStoreIterator500-4 1000000 45666 ns/op
BenchmarkCacheKVStoreIterator1000-4 300000 84568 ns/op
BenchmarkCacheKVStoreIterator10000-4 20000 1447204 ns/op
BenchmarkCacheKVStoreIterator50000-4 2000 17269444 ns/op
BenchmarkCacheKVStoreIterator100000-4 1000 29898436 ns/op
| @@ -146,6 +153,9 @@ func (store *Store) ReverseIterator(start, end []byte) types.Iterator { | |||
| } | |||
|
|
|||
| func (store *Store) iterator(start, end []byte, ascending bool) types.Iterator { | |||
| store.mtx.Lock() | |||
alexanderbez
added a commit
that referenced
this pull request
May 23, 2019
alexanderbez
added a commit
that referenced
this pull request
May 23, 2019
* Cherry Pick PR #4345: Upgrade ledger-cosmos-go * Cherry Pick PR #4336: Fix AppendTags usage error * Update modules * Cherry Pick PR #4265: CacheKVStore keep sorted items * Cherry Pick #4227: Adding support for Ledger Cosmos App v1.5 * Cherry Pick #4395: Improve sig verification error message * Cherry Pick PR #4140: Fix Failed Simulation Seeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2286
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: