-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate genesis before running gentx #3927
Conversation
Signed-off-by: Karoly Albert Szabo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #3927 +/- ##
========================================
Coverage 60.26% 60.26%
========================================
Files 196 196
Lines 14615 14615
========================================
Hits 8808 8808
Misses 5214 5214
Partials 593 593 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PENDING too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a mention in the Gaia stanza of changelog's bugfixes or improvements section: sdkch add gaia bugfixes
Signed-off-by: Karoly Albert Szabo <[email protected]>
My bad, I haven't pushed it |
Closes run validate genesis before running gentx and return error #3825
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: