Gaiad gentx optional flags #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- start testing it Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #3897 +/- ##
==========================================
Coverage ? 60.22%
==========================================
Files ? 196
Lines ? 14551
Branches ? 0
==========================================
Hits ? 8763
Misses ? 5203
Partials ? 585 |
Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
jackzampolin
approved these changes
Mar 18, 2019
Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
alexanderbez
previously requested changes
Mar 20, 2019
There was a problem hiding this comment.
Thanks @sabau! Left a few bits of feedback, but otherwise LGTM 👍
Co-Authored-By: sabau <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
alessio
approved these changes
Mar 27, 2019
There was a problem hiding this comment.
I'd like to see the --name flag turning into a positional argument. It'd be out of scope of the issue we're trying to address here though, thus we'll do it in an ensuing PR.
I'm merging this now (dismissing @alexanderbez comments 'cause AFAICS Karoly ha already addressed them all)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add website, details and identity to gentx
basic coverage for gentx
Closes gaiad gentx should have --website and --detail params #3858
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: