Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Fix query signing-info panic #3417

Merged
merged 4 commits into from
Jan 28, 2019
Merged

R4R: Fix query signing-info panic #3417

merged 4 commits into from
Jan 28, 2019

Conversation

jackzampolin
Copy link
Member

Fixes: #3393

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jan 28, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@bb76903). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             develop    #3417   +/-   ##
==========================================
  Coverage           ?   59.18%           
==========================================
  Files              ?      132           
  Lines              ?     9900           
  Branches           ?        0           
==========================================
  Hits               ?     5859           
  Misses             ?     3669           
  Partials           ?      372

alexanderbez
alexanderbez reviewed Jan 28, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a pending log entry a test case for this?

alexanderbez
alexanderbez suggested changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like CI is still broken?

@jackzampolin
Copy link
Member Author

Fixed.

@jackzampolin jackzampolin merged commit 75c3a44 into develop Jan 28, 2019
@jackzampolin jackzampolin deleted the jack/gaiacli-config-node branch January 28, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio alessio approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackzampolin @alessio @alexanderbez