Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: distr simulation accum invariance #2563

Closed
wants to merge 41 commits into from
Closed

WIP: distr simulation accum invariance #2563

wants to merge 41 commits into from

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Oct 23, 2018 •
edited
Loading

addresses #2573

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

cwgoes and others added 30 commits October 16, 2018 02:18
@cwgoes
Update PENDING.md
1674625
@cwgoes
This PR now will do something else
2fff810
@cwgoes
Merge branch 'develop' into cwgoes/check-supply-in-simulation
67258c4
@cwgoes
Add simulated distribution msgs
b700107
@cwgoes
Correctly set power in vote info
1d4b595
@cwgoes
Merge branch 'develop' into cwgoes/check-supply-in-simulation
74780c6
@cwgoes
Merge branch 'develop' into cwgoes/check-supply-in-simulation
f527163
@cwgoes
Merge PR #2526: Distribution fixes from simulation
e099491
@cwgoes
Merge branch 'develop' into cwgoes/check-supply-in-simulation
06c7e27
@cwgoes
Update stake module simulation and fix linter errors
25ce0de
@cwgoes
Simulation fixes work-in-progress
42ae267
@cwgoes
Linter, enable simulated distribution msgs again
4779359
@cwgoes
Simulation debugging contd.
d21f93a
@cwgoes
Merge branch 'develop' into cwgoes/check-supply-in-simulation
c3d3a79
@cwgoes
Merge branch 'develop' into cwgoes/check-supply-in-simulation
375e821
@cwgoes
Merge branch 'develop' into cwgoes/check-supply-in-simulation
22cb698
@rigelrozanski @cwgoes
bugfix (#2535)
d9916f9
@cwgoes
Remove the print statement
4f719d6
@cwgoes
Add sanity checks
6c9ad8c
@cwgoes
Fixup stake hooks (hopefully...)
2e8f354
@cwgoes
Remove comment
843ccaf
@cwgoes
Simulate minting, fix bug where pool was not updated
1afb5bf
@cwgoes
Use InflateSupply instead
dc13a0c
@rigelrozanski
use power instead of total tokens
a6ef3c4
@cwgoes
Withdraw rewards on bonded to unbonding
7770aec
@cwgoes
Cleanup to one hook
255a6a5
@cwgoes
Fix linter issues
c88fc48
@cwgoes
Merge branch 'develop' into cwgoes/check-supply-in-simulation
c9e5c32
@jaekwon
Update naming (BondedValidatorIndex->ValidatorsBondedIndex) and add s…
3fa5778 
…ome comments
@jaekwon
GetValidatorsBonded -> LastValidators etc
015b829
jaekwon and others added 11 commits October 21, 2018 15:28
@rigelrozanski rigelrozanski changed the base branch from cwgoes/check-supply-in-simulation to develop October 23, 2018 16:45
@rigelrozanski rigelrozanski changed the title distribution get accum WIP: distr simulation accum invariance Oct 23, 2018
@cwgoes cwgoes added T: Tests wip C:x/distribution distribution module related labels Oct 23, 2018
@rigelrozanski
Copy link
Contributor Author

replaced by #2597

@rigelrozanski rigelrozanski deleted the rigel/distr-get-accum branch October 25, 2018 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
C:x/distribution distribution module related T: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rigelrozanski @cwgoes @jaekwon