Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basecoin fix (replaces #1919) #1940

Closed
wants to merge 1 commit into from
Closed

Basecoin fix (replaces #1919) #1940

wants to merge 1 commit into from

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Aug 8, 2018

Replaces #1919 which was mistakenly based off of master.

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes mentioned this pull request Aug 8, 2018
9 tasks
@codecov
Copy link

codecov bot commented Aug 8, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@1da1115). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1940   +/-   ##
==========================================
  Coverage           ?   64.82%           
==========================================
  Files              ?      114           
  Lines              ?     6804           
  Branches           ?        0           
==========================================
  Hits               ?     4411           
  Misses             ?     2114           
  Partials           ?      279

@ValarDragon
Copy link
Contributor

Can we close this and cherry-pick @gblue123's commit?

@ValarDragon ValarDragon closed this Aug 8, 2018
@cwgoes cwgoes deleted the cwgoes/basecoin-fix branch August 8, 2018 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants