Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: automate EventTypeMessage inclusion in every message execution #13532

Merged
merged 23 commits into from
Oct 16, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 13, 2022

Description

Closes: #11868


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt marked this pull request as ready for review October 13, 2022 13:02
@julienrbrt julienrbrt requested a review from a team as a code owner October 13, 2022 13:02
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #13532 (64abeb9) into main (d9f3eb0) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13532      +/-   ##
==========================================
- Coverage   54.08%   53.93%   -0.15%     
==========================================
  Files         652      645       -7     
  Lines       56244    55681     -563     
==========================================
- Hits        30418    30033     -385     
+ Misses      23380    23223     -157     
+ Partials     2446     2425      -21     
Impacted Files Coverage Δ
x/auth/vesting/msg_server.go 72.14% <ø> (-3.49%) ⬇️
x/bank/keeper/msg_server.go 54.79% <ø> (-5.40%) ⬇️
x/bank/types/events.go 0.00% <ø> (ø)
x/consensus/keeper/msg_server.go 100.00% <ø> (ø)
x/crisis/keeper/msg_server.go 18.00% <ø> (+1.63%) ⬆️
x/distribution/keeper/msg_server.go 0.00% <ø> (ø)
x/evidence/keeper/msg_server.go 0.00% <ø> (ø)
x/slashing/keeper/msg_server.go 82.60% <ø> (+21.31%) ⬆️
x/staking/keeper/msg_server.go 3.26% <ø> (+0.20%) ⬆️
baseapp/baseapp.go 75.12% <100.00%> (+0.06%) ⬆️
... and 10 more

@@ -67,6 +67,21 @@ the correct code.

### Modules

#### `**all**`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

baseapp/baseapp.go Show resolved Hide resolved
baseapp/baseapp.go Outdated Show resolved Hide resolved
baseapp/baseapp.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt enabled auto-merge (squash) October 13, 2022 19:26
@julienrbrt julienrbrt disabled auto-merge October 13, 2022 19:33
@julienrbrt julienrbrt requested a review from tac0turtle October 13, 2022 19:33
@tac0turtle
Copy link
Member

@aaronc want to look at this?

@julienrbrt julienrbrt requested a review from aaronc October 14, 2022 22:53
@alexanderbez alexanderbez merged commit 3c9b244 into main Oct 16, 2022
@alexanderbez alexanderbez deleted the julien/hooks branch October 16, 2022 23:00
0Tech added a commit to Finschia/finschia-sdk that referenced this pull request Aug 10, 2023
…ion (backport cosmos/cosmos-sdk#13532) (#1063)

* refactor: automate EventTypeMessage inclusion in every message execution (#13532)

* Fix the test requirement and leave the hint

* Update CHANGELOG.md

* Lint

* Update CHANGELOG.md

---------

Co-authored-by: Julien Robert <[email protected]>
0Tech added a commit to 0Tech/finschia-sdk that referenced this pull request Aug 24, 2023
…ion (backport cosmos/cosmos-sdk#13532) (Finschia#1063)

* refactor: automate EventTypeMessage inclusion in every message execution (#13532)

* Fix the test requirement and leave the hint

* Update CHANGELOG.md

* Lint

* Update CHANGELOG.md

---------

Co-authored-by: Julien Robert <[email protected]>
0Tech added a commit to Finschia/finschia-sdk that referenced this pull request Aug 24, 2023
…ion (backport #1063) (#1090)

* refactor: automate EventTypeMessage inclusion in every message execution (backport cosmos/cosmos-sdk#13532) (#1063)

* refactor: automate EventTypeMessage inclusion in every message execution (#13532)

* Fix the test requirement and leave the hint

* Update CHANGELOG.md

* Lint

* Update CHANGELOG.md

---------

Co-authored-by: Julien Robert <[email protected]>

* Update CHANGELOG.md

---------

Co-authored-by: Julien Robert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate EventTypeMessage inclusion in every message execution
4 participants