From bd050ae2157ac7c814a9e0a8277b1f2811ad975b Mon Sep 17 00:00:00 2001 From: foxytanuki Date: Sun, 24 Apr 2022 21:48:16 +0900 Subject: [PATCH 1/2] docs: fix typo --- docs/core/encoding.md | 2 +- docs/core/transactions.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/core/encoding.md b/docs/core/encoding.md index e7a9e330f048..7136d6c8e94b 100644 --- a/docs/core/encoding.md +++ b/docs/core/encoding.md @@ -247,7 +247,7 @@ may simply migrate any existing types that are encoded and persisted via their concrete Amino codec to Protobuf (see 1. for further guidelines) and accept a `Marshaler` as the codec which is implemented via the `ProtoCodec` without any further customization. -However, if a module type composes an interface, it must wrap it in the `skd.Any` (from `/types` package) type. To do that, a module-level .proto file must use [`google.protobuf.Any`](https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/any.proto) for respective message type interface types. +However, if a module type composes an interface, it must wrap it in the `sdk.Any` (from `/types` package) type. To do that, a module-level .proto file must use [`google.protobuf.Any`](https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/any.proto) for respective message type interface types. For example, in the `x/evidence` module defines an `Evidence` interface, which is used by the `MsgSubmitEvidence`. The structure definition must use `sdk.Any` to wrap the evidence file. In the proto file we define it as follows: diff --git a/docs/core/transactions.md b/docs/core/transactions.md index ca146e81d706..2b8eb096de64 100644 --- a/docs/core/transactions.md +++ b/docs/core/transactions.md @@ -79,7 +79,7 @@ Module `sdk.Msg`s are not to be confused with [ABCI Messages](https://tendermint **Messages** (or `sdk.Msg`s) are module-specific objects that trigger state transitions within the scope of the module they belong to. Module developers define the messages for their module by adding methods to the Protobuf [`Msg` service](../building-modules/msg-services.md), and also implement the corresponding `MsgServer`. -Each `sdk.Msg`s is related to exactly one Protobuf [`Msg` service](../building-modules/msg-services.md) RPC, defined inside each module's `tx.proto` file. An SKD app router automatically maps every `sdk.Msg` to a corresponding RPC. Protobuf generates a `MsgServer` interface for each module `Msg` service, and the module developer needs to implement this interface. +Each `sdk.Msg`s is related to exactly one Protobuf [`Msg` service](../building-modules/msg-services.md) RPC, defined inside each module's `tx.proto` file. A SDK app router automatically maps every `sdk.Msg` to a corresponding RPC. Protobuf generates a `MsgServer` interface for each module `Msg` service, and the module developer needs to implement this interface. This design puts more responsibility on module developers, allowing application developers to reuse common functionalities without having to implement state transition logic repetitively. To learn more about Protobuf `Msg` services and how to implement `MsgServer`, click [here](../building-modules/msg-services.md). From abdc82a21f161754e740cf2682e2a140c1c30c49 Mon Sep 17 00:00:00 2001 From: foxytanuki Date: Sun, 24 Apr 2022 21:48:58 +0900 Subject: [PATCH 2/2] docs: fix broken link --- docs/basics/tx-lifecycle.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/basics/tx-lifecycle.md b/docs/basics/tx-lifecycle.md index 8209e2c518a5..7845b733e376 100644 --- a/docs/basics/tx-lifecycle.md +++ b/docs/basics/tx-lifecycle.md @@ -54,7 +54,7 @@ The command-line is an easy way to interact with an application, but `Tx` can al Each full-node (running Tendermint) that receives a `Tx` sends an [ABCI message](https://tendermint.com/docs/spec/abci/abci.html#messages), `CheckTx`, to the application layer to check for validity, and receives an `abci.ResponseCheckTx`. If the `Tx` passes the checks, it is held in the nodes' -[**Mempool**](https://tendermint.com/docs/tendermint-core/mempool.html#mempool), an in-memory pool of transactions unique to each node) pending inclusion in a block - honest nodes will discard `Tx` if it is found to be invalid. Prior to consensus, nodes continuously check incoming transactions and gossip them to their peers. +[**Mempool**](https://tendermint.com/docs/tendermint-core/mempool), an in-memory pool of transactions unique to each node) pending inclusion in a block - honest nodes will discard `Tx` if it is found to be invalid. Prior to consensus, nodes continuously check incoming transactions and gossip them to their peers. ### Types of Checks