Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: support debug trace QueryResult (backport #9576) #11148

Merged
merged 1 commit into from
Feb 18, 2022
Merged

feat!: support debug trace QueryResult (backport #9576) #11148

merged 1 commit into from
Feb 18, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Feb 9, 2022

Description

backport #9576

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@yihuang yihuang mentioned this pull request Feb 9, 2022
Merged
13 tasks
amaury1093
amaury1093 reviewed Feb 9, 2022
View reviewed changes
types/errors/abci.go Outdated
@@ -95,8 +95,8 @@ func ResponseDeliverTxWithEvents(err error, gw, gu uint64, events []abci.Event,

// QueryResult returns a ResponseQuery from an error. It will try to parse ABCI
// info from the error.
func QueryResult(err error) abci.ResponseQuery {
space, code, log := ABCIInfo(err, false)
func QueryResult(err error, debug bool) abci.ResponseQuery {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot backport this function, because it's API-breaking.

What we can do is create a new function QueryResultWithDebug, does that work for you @yihuang ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK -- create a QueryResultWithDebug 👍

Copy link
Collaborator Author

@yihuang yihuang Feb 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the suggestions, it's changed now.

@yihuang yihuang force-pushed the v0.45.1-debug-query-result branch from 9681d0e to 7345f7e Compare February 10, 2022 01:27
amaury1093
amaury1093 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

types/errors/abci.go Show resolved Hide resolved
@yihuang @amaury1093
support debug trace QueryResult
2cdb638 
Update types/errors/abci.go

Co-authored-by: Amaury <[email protected]>
@yihuang yihuang force-pushed the v0.45.1-debug-query-result branch from 6a1fdf9 to 2cdb638 Compare February 14, 2022 14:33
likhita-809
likhita-809 approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yihuang
Copy link
Collaborator Author

yihuang commented Feb 18, 2022

shall we merge this to 0.45.x?

@tac0turtle tac0turtle merged commit 7f949c0 into cosmos:release/v0.45.x Feb 18, 2022
@yihuang yihuang deleted the v0.45.1-debug-query-result branch February 18, 2022 08:59
@faddat faddat mentioned this pull request Feb 28, 2022
Closed
8 tasks
zakir-code pushed a commit to PundiAI/cosmos-sdk that referenced this pull request Apr 14, 2022
@yihuang @amaury1093
support debug trace QueryResult (cosmos#11148)
842d5b2 
Update types/errors/abci.go

Co-authored-by: Amaury <[email protected]>

Co-authored-by: Amaury <[email protected]>
JimLarson pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Jul 7, 2022
@yihuang @amaury1093 @JimLarson
support debug trace QueryResult (cosmos#11148)
15a31d9 
Update types/errors/abci.go

Co-authored-by: Amaury <[email protected]>

Co-authored-by: Amaury <[email protected]>
randy75828 pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 10, 2022
@yihuang @amaury1093 @randy75828
support debug trace QueryResult (cosmos#11148)
e224f91 
Update types/errors/abci.go

Co-authored-by: Amaury <[email protected]>

Co-authored-by: Amaury <[email protected]>
randy75828 pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 10, 2022
@yihuang @amaury1093 @randy75828
support debug trace QueryResult (cosmos#11148)
126ee72 
Update types/errors/abci.go

Co-authored-by: Amaury <[email protected]>

Co-authored-by: Amaury <[email protected]>
p0mvn pushed a commit to osmosis-labs/cosmos-sdk that referenced this pull request Oct 12, 2022
@yihuang @p0mvn
backport support debug trace QueryResult (cosmos#11148)
90e3eff
@p0mvn p0mvn mentioned this pull request Oct 12, 2022
Merged
p0mvn added a commit to osmosis-labs/cosmos-sdk that referenced this pull request Oct 13, 2022
@p0mvn @yihuang
backport support debug trace QueryResult (cosmos#11148) (#347)
4b35574 
Co-authored-by: yihuang <[email protected]>
mergify bot pushed a commit to osmosis-labs/cosmos-sdk that referenced this pull request Oct 13, 2022
@p0mvn @mergify
backport support debug trace QueryResult (cosmos#11148) (#347)
c680a8e 
Co-authored-by: yihuang <[email protected]>
(cherry picked from commit 4b35574)
p0mvn added a commit to osmosis-labs/cosmos-sdk that referenced this pull request Oct 13, 2022
@mergify @p0mvn
backport support debug trace QueryResult (cosmos#11148) (#347) (#350)
82e1aa6 
Co-authored-by: yihuang <[email protected]>
(cherry picked from commit 4b35574)

Co-authored-by: Roman <[email protected]>
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@yihuang @amaury1093 @JeancarloBarrios
support debug trace QueryResult (cosmos#11148)
f8778c3 
Update types/errors/abci.go

Co-authored-by: Amaury <[email protected]>

Co-authored-by: Amaury <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhita-809 likhita-809 likhita-809 approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees

@likhita-809 likhita-809

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yihuang @amaury1093 @alexanderbez @likhita-809 @tac0turtle