Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmovisor v2 #9869

Closed
3 tasks
robert-zaremba opened this issue Aug 6, 2021 · 6 comments
Closed
3 tasks

Cosmovisor v2 #9869

robert-zaremba opened this issue Aug 6, 2021 · 6 comments
Labels
C:Cosmovisor Issues and PR related to Cosmovisor S:needs architecture Needs a architecture proposal for how the feature will be implemented

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Aug 6, 2021

Epic Tasks

This issues is not a discussion, we should limit amount of comments here.

  • Graceful shutdown with tendermint
  • Support running external binaries (eg: cosmwasm)
  • Support updating external binaries (eg: cosmwasm)
@ethanfrey
Copy link
Contributor

Support running external binaries (eg: cosmwasm)

??

We have run cosmovisor successfully with wasmd several months ago. We hit one issue when it outputted enormously long lines (we used to dump the wasm code as base64 in the logs) and this killed the cosmovisor headline process, leading to a nasty crash when someone uploaded code.

Other than that (which we fixed with our logging), we didn't have issues. There is no external binary, it is just a dll built into the binary (using static builds / alpine linux). Maybe this is different for glibc and the shared dll and that is what you are referring to?

What is really missing for CosmWasm is state sync support. I'd love to see some hooks so we could add a way to sync wasm code. Just the hooks, I can do the rest.

@robert-zaremba robert-zaremba changed the title Cosmovisor improvements Cosmovisor v2 Aug 6, 2021
@robert-zaremba
Copy link
Collaborator Author

Let's chat about the wasmd setup. State sync is a different epic which we are also planning.

@aaronc
Copy link
Member

aaronc commented Aug 7, 2021

I think it's too early to start an epic. We don't have things clearly scoped so please let's convert this issue to a discussion to get more clarity. The tendermint stuff is also still in design and will likely affect x/upgrade + BaseApp as well.

@ethanfrey
Copy link
Contributor

TL;DR

If you can swap binaries that should be enough for wamsd.

Ideally you could run docker images from cosmovisor, and/or allow us to set an environmental variable for each version. Those would be the only requests I could make

@robert-zaremba
Copy link
Collaborator Author

I've created a discussion to specify Cosmovisr v2.

@robert-zaremba robert-zaremba added the S:needs architecture Needs a architecture proposal for how the feature will be implemented label Aug 19, 2021
@clevinson
Copy link
Contributor

Closing this issue so further comments can move to the discussion. Let's open issues again once we have specific features defined later down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Cosmovisor Issues and PR related to Cosmovisor S:needs architecture Needs a architecture proposal for how the feature will be implemented
Projects
None yet
Development

No branches or pull requests

4 participants