-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ed25519 proto compatible with ADR-28 #9227
Comments
Title is off |
@robert-zaremba is this something which is still of interest? |
We're working on this #7315 and believe when merging it will cover the proto message requested here. |
Started working into this issue |
Got the implementation of said ADR address, seems it provoked errors on nodes and validators. This won't be backwards compatible so I'm working on figuring out how severe is the impact, are we sure we want to proceed with this? @tac0turtle |
It affects the validators and the block interaction, seems like when a validator is initialized with an ed25519 key with the new address it is unable to receive blocks, or a block is unable to find such validator. It is still unclear what is causing the misscomunication on the existing tests if nor the keys neither the addresses are being hardcoded |
this will be on hold until the implementation of ADR071 is completed. |
As the [ADR-071] Cryptography v2 #18824 was splitted into the Base crypto providers development app in this ADR, and then the SDK implementation, this issue will be fixed. |
Summary
Some chains will like to opt-in for ed25519 for user accounts. Let's implement an ADR-28 compatible keys for them.
Ref: #8543 (comment)
Problem Definition
Currently, we don't support ed25519 for user keys. Custom implementation could not be compatible with ADR-28 and could lead to potential design conflicts in the future.
For Admin Use
The text was updated successfully, but these errors were encountered: