Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ed25519 proto compatible with ADR-28 #9227

Open
3 of 4 tasks
Tracked by #18022
robert-zaremba opened this issue Apr 28, 2021 · 8 comments
Open
3 of 4 tasks
Tracked by #18022

Create ed25519 proto compatible with ADR-28 #9227

robert-zaremba opened this issue Apr 28, 2021 · 8 comments
Assignees
Labels
C:Crypto C:Keys Keybase, KMS and HSMs

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Apr 28, 2021

Summary

Some chains will like to opt-in for ed25519 for user accounts. Let's implement an ADR-28 compatible keys for them.

Ref: #8543 (comment)

Problem Definition

Currently, we don't support ed25519 for user keys. Custom implementation could not be compatible with ADR-28 and could lead to potential design conflicts in the future.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added C:Keys Keybase, KMS and HSMs C:Crypto labels Apr 28, 2021
@alexanderbez
Copy link
Contributor

Title is off

@robert-zaremba robert-zaremba changed the title Create Create ed25519 ADR-28 proto May 7, 2021
@github-actions github-actions bot added the stale label Jul 15, 2021
@ryanchristo ryanchristo reopened this Jul 26, 2021
@github-actions github-actions bot closed this as completed Aug 2, 2021
@robert-zaremba robert-zaremba changed the title Create ed25519 ADR-28 proto Create ed25519 proto compatible with ADR-28 Aug 3, 2021
@robert-zaremba robert-zaremba reopened this Aug 3, 2021
@github-actions github-actions bot added the stale label Sep 18, 2021
@IdaTucker
Copy link

@robert-zaremba is this something which is still of interest?

@ainhoa-a
Copy link

We're working on this #7315 and believe when merging it will cover the proto message requested here.

@bizk bizk self-assigned this Aug 15, 2023
@bizk
Copy link
Contributor

bizk commented Aug 15, 2023

Started working into this issue

@bizk
Copy link
Contributor

bizk commented Aug 21, 2023

Got the implementation of said ADR address, seems it provoked errors on nodes and validators. This won't be backwards compatible so I'm working on figuring out how severe is the impact, are we sure we want to proceed with this? @tac0turtle

cc: @raynaudoe @JulianToledano

@bizk
Copy link
Contributor

bizk commented Aug 22, 2023

It affects the validators and the block interaction, seems like when a validator is initialized with an ed25519 key with the new address it is unable to receive blocks, or a block is unable to find such validator. It is still unclear what is causing the misscomunication on the existing tests if nor the keys neither the addresses are being hardcoded

@educlerici-zondax
Copy link
Contributor

this will be on hold until the implementation of ADR071 is completed.
After that, we can assess the possibility of applying these changes.

@educlerici-zondax
Copy link
Contributor

As the [ADR-071] Cryptography v2 #18824 was splitted into the Base crypto providers development app in this ADR, and then the SDK implementation, this issue will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Crypto C:Keys Keybase, KMS and HSMs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants