Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow state access in authorizations #8468

Closed
anilcse opened this issue Jan 28, 2021 · 2 comments
Closed

Allow state access in authorizations #8468

anilcse opened this issue Jan 28, 2021 · 2 comments

Comments

@anilcse
Copy link
Collaborator

anilcse commented Jan 28, 2021

ref #8462 (comment) #8462 (comment)
While implementing VoteAuthorization as part of #8312, we needed access to the state to verify ProposalType against authorized ProposalTypes. For now there's no clean way to access the state (read-only should suffice) and validate certain authorization constraints. This will limit the granular authorizations and forces everyone to use just GenericAuthorization without any Msg specific limitations.
Allowing a way to read the state from authorization (inside Accept) would enable more freedom for users to make granular authorizations.

@aaronc
Copy link
Member

aaronc commented Jan 28, 2021

Enabling at least the query part of ADR 033 seems like a clean way to address this.

@github-actions github-actions bot added the stale label Sep 2, 2021
@tac0turtle tac0turtle removed the stale label Mar 31, 2023
@tac0turtle
Copy link
Member

after discussions with the security team we have opted to create an authorization account type via accounts. Users can extend the account whichever way they would like without needing to fork as well. No need to modify authz further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants