-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve multiple signer UX for protobuf signing over SIGN_MODE_DIRECT #8141
Comments
I'm advocating to use Schnorr MultiSig to implement in SDK. It's much more efficient in terms of interactions and preserves privacy. I created an issue to document the motivation and proposed implementation: #7315 |
Now that ADR028 is implemented, should we revisit this conversation? I understand that group module is where we want to move for many multisig uses cases, but htere are still valid reasons for sometimes wanting off-chain multisig. Having an discussion about how we plan to address this (and whether Schnorr sigs play a role in a solution) IMO would be valuable. |
Can anyone recall the problem with current, legacy multisig? It doesn't support sign_mode_direct, but is it a pain? |
Note that, both Schnorr signatures and x/group works with sign_mode_direct:
|
So, I would propose on finalizing x/group and implementing Schnorr and deprecating the legacy multisig (let it die) rather than trying to fix the latter. |
In my view, it's just a question of support. As long as legacy multisig support is guaranteed, I'm fine with both Schnorr sigs and x/group. In other words: we just can't just drop legacy multisig support. There are loads of funds held behind those keys. (CC'ing also @zmanian and @alexanderbez for visibility) |
I am very much in favor of a migration path from legacy multisig -> group |
+1 |
Closing this in favor of #9406, which will resolve the issue |
Sorry, is there any way of using Schnorr signing for multisig, currently? I found another issue, but not sure if it just related to Cosmos SDKs implementation only or there is no available implementation in general. |
@poiug07vsys currently, Schnorr based multisig is not implemented. The issue you linked is the tracking issue. |
Problem Definition
The current implementation of multisig in stargate uses
legacy_amino
Sign mode, assign_mode_direct
requires all the signers to be set beforehand.There were a couple of solutions proposed before (check #6078 (comment)), but no consensus was reached.
Proposal
I propose to revisit the options, as to improve the multisig design for the next versions
cc\ @alessio @aaronc @zmanian
For Admin Use
The text was updated successfully, but these errors were encountered: