-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinguish Authentication and Authorization #7615
Comments
ACK |
👍 |
ACK |
* Add ADR 030 * Cleanup * Updates * Updates based on ADR 031 * Add abstract and context * Updates * Update module name as per #7615 * Updates from reviews * Rename * CLI update * Update docs/architecture/adr-030-authz-module.md Co-authored-by: Robert Zaremba <[email protected]> * Update docs/architecture/adr-030-authz-module.md Co-authored-by: Robert Zaremba <[email protected]> * Update docs/architecture/adr-030-authz-module.md Co-authored-by: Robert Zaremba <[email protected]> * Update docs/architecture/adr-030-authz-module.md Co-authored-by: Robert Zaremba <[email protected]> * Code review updates * Update docs Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: Robert Zaremba <[email protected]>
I don't understand why are we introducing such a breaking change. Couldn't we just name the |
I don't see an issue with reading as We originally were just calling |
why don't we just rename |
One (possibly bad) reason not to do this is because it makes protobuf type URLs longer - We could also have |
I don't have a strong opinion on the authz renaming, but I'm strongly against the auth -> authn renaming because it's such a large breaking change for other applications |
@alexanderbez do you have any thoughts here? We moved forward because you ACK'ed but I would be fine keeping |
IMHO |
Totally fine to postpone it |
Moving to icebox as this will ideally be addressed in the x /auth & x/bank refactor. Possibly with two modules in parallel (new & old auth / authz). |
A proposed API for a new |
Summary
x/auth
->x/authn
x/msg_authorization
module (ADR 030: Authorization Module #7105 WIP: Addx/msg_authorization
module #7370) ->x/authz
Problem Definition
We will have two modules with the abbreviation
auth
in their name but which deal with two slightly different concerns.x/auth
deals primarily with "authentication". From Oxford authentication isx/msg_authorization
deals with what an "authenticated" user is "authorized" to do. From Oxford authorization isWhich seems pretty consistent with what
x/msg_authorization
does.Proposal
There is a fair amount of precedent for using
authn
andauthz
as abbreviations for authentication and authorization respectively, as well as forauth
alone being confusing:So how about
x/auth
becomesx/authn
andx/msg_authorization
becomesx/authz
?For Admin Use
The text was updated successfully, but these errors were encountered: