Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace clientexported.Height with proto Height #6888

Closed
AdityaSripal opened this issue Jul 30, 2020 · 1 comment
Closed

Replace clientexported.Height with proto Height #6888

AdityaSripal opened this issue Jul 30, 2020 · 1 comment
Assignees
@AdityaSripal
Milestone
IBC 1.0 [Implemen...

Comments

@AdityaSripal
Copy link
Member

AdityaSripal commented Jul 30, 2020 •
edited by fedekunze
Loading

Currently the abstract Height is implemented as a struct in client/exported, this must be turned to a proto struct during the 02-client migration.

Once, this is done then the workaraound of including epochNumber and epochHeight as two separate uint64 fields in the proto files of connection and channel, can be replaced by just the Height proto message.

ref #6686, #6630
@fedekunze fedekunze added this to the IBC 1.0 milestone Jul 30, 2020
@fedekunze
Copy link
Collaborator

closed via #7211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdityaSripal AdityaSripal

Labels
None yet
Projects
None yet
Milestone
IBC 1.0 [Implementation]
Development

No branches or pull requests
2 participants
@AdityaSripal @fedekunze