Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module interface registration #6834

Merged
merged 7 commits into from
Jul 24, 2020
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jul 24, 2020

Previously InterfaceModule had been added as a separate module interface from AppModule.... It turns out that almost all modules need to register some interfaces (usually for sdk.Msg at a minimum. So separating this doesn't make sense. Also x/slashing and x/staking were missing interface registrations.

This PR:

  • merges the InterfaceModule functionality into AppModuleBasic, renaming RegisterInterfaceTypes -> RegisterInterfaces
  • adds missing registrations for x/slashing and x/staking

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #6834 into master will increase coverage by 3.27%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master    #6834      +/-   ##
==========================================
+ Coverage   61.40%   64.68%   +3.27%     
==========================================
  Files         414      379      -35     
  Lines       25084    23651    -1433     
==========================================
- Hits        15404    15298     -106     
+ Misses       8398     7218    -1180     
+ Partials     1282     1135     -147     

@aaronc aaronc added T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). C:Encoding A:automerge Automatically merge PR once all prerequisites pass. labels Jul 24, 2020
@aaronc aaronc marked this pull request as ready for review July 24, 2020 01:57
@aaronc aaronc mentioned this pull request Jul 24, 2020
9 tasks
@aaronc aaronc merged commit 1538e65 into master Jul 24, 2020
@aaronc aaronc deleted the aaronc/fix-interface-module branch July 24, 2020 02:45
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Encoding T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants