Should delegators vote be overridden by validators if delegators vote before validators?

[kwunyeung]

I am verifying the votes on proposal 23. The following are the numbers we see at height 508255.

{
    height: "508255",
    result: {
         yes: "118188092215360",
         abstain: "4846296869440",
         no: "5280430058143",
         no_with_veto: "549999"
    }
}

The number of No votes casted can be added up correctly with the individual votes we found. However, this seems not right with the spec of gov module regarding inheritance is explaining.

https://github.com/cosmos/cosmos-sdk/blob/master/x/gov/spec/01_concepts.md#inheritance

It says,

If the delegator votes before its validator, it will not inherit from the validator's vote.

In my understanding, it means if the validator votes after the delegator, the validator can't override the vote of the delegator. This is not the case in the current tally result. 500K of our delegation is from DokiaCapital which they have voted before Forbole.

https://cosmos.bigdipper.live/validator/cosmosvaloper14kn0kk33szpwus9nh8n87fjel8djx0y070ymmj/delegations

I expect the total votes from Forbole would be 500K less than 3.4M but this is not the case. Does validator's vote after delegator override the vote of delegator's original vote? Am I interpreting the meaning of the spec wrongly?

[gavinly]

Glad that you're verifying! 🙏

[sunnya97]

@kwunyeung Thanks for verifying! This is a known bug, where the tally function was incorrectly handling validators who delegated to other validators (order of votes doesn't matter).

The bug was fixed here: #5107

However, this bug fix wasn't included in the code for cosmoshub-3 and hasn't made it onto the Hub yet. It will be included in the next upgrade.