Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeout execution handling #5511

Closed
cwgoes opened this issue Jan 10, 2020 · 6 comments
Closed

Fix timeout execution handling #5511

cwgoes opened this issue Jan 10, 2020 · 6 comments
Assignees
@cwgoes
Milestone
IBC 1.0 [Implemen...

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jan 10, 2020

Ref #5401 (comment)

How is this intended to work?
@cwgoes cwgoes added the x/ibc label Jan 10, 2020
@cwgoes cwgoes mentioned this issue Jan 10, 2020
Merged
11 tasks
@fedekunze
Copy link
Collaborator

bump @mossid

@fedekunze fedekunze added this to the IBC Implementation milestone Jan 21, 2020
@fedekunze
Copy link
Collaborator

@mossid can you comment on this issue please?

@mossid
Copy link
Contributor

mossid commented Jan 29, 2020 •
edited
Loading

TimeoutExecuted function should be called inside the app level handlers, after the timeout execution.(same pattern with packetexecuted)

@cwgoes
Copy link
Contributor Author

cwgoes commented Feb 3, 2020

TimeoutExecuted function should be called inside the app level handlers, after the timeout execution.(same pattern with packetexecuted)

I see. I think a wrapper function would be helpful in both places - it's easy to "forget" to call the TimeoutExected or PacketExecuted function by accident.

@cwgoes cwgoes self-assigned this Feb 3, 2020
This was referenced Feb 3, 2020
Merged
Merged
@cwgoes
Copy link
Contributor Author

cwgoes commented Feb 3, 2020

For now TimeoutExecuted is called in #5603 but I still think we should consider a wrapper function.

@fedekunze
Copy link
Collaborator

closed via #5577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwgoes cwgoes

Labels
None yet
Projects
None yet
Milestone
IBC 1.0 [Implementation]
Development

No branches or pull requests
3 participants
@mossid @cwgoes @fedekunze